Zachary Ware added the comment:
I decided not to backport. If anyone else would like to, I won't stand in
their way.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.5
___
Python
Roundup Robot added the comment:
New changeset 4e5b3dc049cc by Zachary Ware in branch 'default':
Issue #25387: Check return value of winsound.MessageBeep
https://hg.python.org/cpython/rev/4e5b3dc049cc
--
nosy: +python-dev
___
Python tracker
Zachary Ware added the comment:
Here's a patch. This has the possibility of breaking existing code, but the
fix is simple (just catch RuntimeError) and is probably more in line with
what's expected.
--
keywords: +patch
stage: needs patch -> patch review
Added file:
Zachary Ware added the comment:
Though the source link is incredibly out of date (we've been on hg.python.org
for about 5 years now, and are soon to move to Github), this is a current
issue. The suggested 'example "fix"' is not applicable, though; in that case,
MessageBeep is just used in
New submission from Alexander Riccio:
A really minor issue (probably qualifies for the "easy" keyword):
sound_msgbeep (in http://svn.python.org/projects/python/trunk/PC/winsound.c)
doesn't check the return value of MessageBeep
Changes by Alexander Riccio :
--
components: Windows
nosy: Alexander Riccio, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: sound_msgbeep doesn't check the return value of MessageBeep
type: behavior
versions: