[issue25449] Test OrderedDict subclass

2015-10-21 Thread Eric Snow
Eric Snow added the comment: Regarding dict.__setitem__, see issue #24726. Raymond outlined what needs to be fixed. -- ___ Python tracker ___

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Eric Snow
Changes by Eric Snow : -- stage: commit review -> patch review ___ Python tracker ___

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New patch adds PurePythonOrderedDictSubclassTests, moves all tests except test_key_change_during_iteration from CPythonOrderedDictTests to OrderedDictTests to test Python implementation too, fixes a bug in values and items iteration that caused

[issue25449] Test OrderedDict subclass

2015-10-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch was not ready for commit. The problem is that test_issue24347 fails in CPythonOrderedDictSubclassTests. The failure is random, you need to run test several times to encounter it. Experimenting with this test I found other bug probably related to

[issue25449] Test OrderedDict subclass

2015-10-20 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: C implementation of OrderedDict often has two paths. One for exact OrderedDict and other for subclasses. But only one of the paths is tested. Proposed patch adds tests for a subclass of C implemented OrderedDict. test_issue24347 is failed with OrderedDict

[issue25449] Test OrderedDict subclass

2015-10-20 Thread Eric Snow
Eric Snow added the comment: LGTM as long as you also add PurePythonOrderedDictSubclassTests to match CPythonOrderedDictSubclassTests (per PEP 399). -- nosy: +eric.snow stage: -> commit review ___ Python tracker