[issue25571] Improve the lltrace feature with the Py_Debug mode

STINNER Victor added the comment: I suggest to wait until sys.settrace() supports bytecode level tracing, then rewrite lltrace on top of it, open a new issue to remove C lltrace and close this issue. You need to write to python-dev if you want to remove the current C lltrace. --

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: @gwk no problem for a review of your patch @haypo as discussed before, maybe we could remove the lltrace feature because this one is never used by the developers. or we could ask on @python-dev ML. If there is a better solution and this one could replace

[issue25571] Improve the lltrace feature with the Py_Debug mode

STINNER Victor added the comment: I still strongly prefer bpo-29400 over "lltrace", since it would be usable in release mode. -- ___ Python tracker ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

George King added the comment: @matrixise, I'm the author of the alternative in issue29400, and I'm finally finding the time to get back into it. I'm going to make a push this week to clean it up; your feedback would be much appreciated! -- nosy: +gwk

[issue25571] Improve the lltrace feature with the Py_Debug mode

STINNER Victor added the comment: https://bugs.python.org/issue29400 -- ___ Python tracker ___ ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: @haypo, you told me there is an alternative to my patch, provided by an other dev. what's the bpo issue for the alternative. -- ___ Python tracker

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: I have to update my patch to python-3.7, I will provide a patch asap. -- ___ Python tracker ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

Changes by Stéphane Wirtel : -- assignee: -> haypo ___ Python tracker ___ ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

Emanuel Barry added the comment: Maybe someone who knows this feature better can weigh in, but otherwise LGTM. -- ___ Python tracker ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Here is a new version of my patch "issue25571-4.diff" with the comments of Emanuel Barry. -- Added file: http://bugs.python.org/file43997/issue25571-4.diff ___ Python tracker

[issue25571] Improve the lltrace feature with the Py_Debug mode

Changes by A Kaptur : -- nosy: +akaptur ___ Python tracker ___ ___ Python-bugs-list

[issue25571] Improve the lltrace feature with the Py_Debug mode

Emanuel Barry added the comment: Left some comments on Rietveld; mostly documentation-related (and pointed out some typos). I'm also +1 on having to specify a True value rather than just defining the variable at all (i.e. setting __ltrace__ to False is the same as not defining it). If you

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Here is a small patch for the __ltrace__ feature. I would like to propose a new test, __ltrace__ should be defined in the globals() dictionary and there is no check on the value associated to this key. Maybe we could defined it as a boolean, True or False.

[issue25571] Improve the lltrace feature with the Py_Debug mode

STINNER Victor added the comment: Sorry, I don't know what is the best place to add new unit tests. I don't know neither what is the best place to document the __ltrace__ feature. Maybe somewhere near: * https://docs.python.org/dev/library/debug.html Or maybe: *

[issue25571] Improve the lltrace feature with the Py_Debug mode

STINNER Victor added the comment: It would be nice to have unit tests and docs :-) For unit test, you can use a script like: --- def func(): return 1 __ltrace__ = True func() --- Run the script with test.support.assert_python_ok(), and check stdout. To skip the test if Python is compiled

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Totally agree with you, I am going to check that, because currently, there is no test with this "hidden" feature in Python. I am going to discuss with Victor about this point. Thanks, Stephane On 07/20, Xavier Combelle wrote: > >Xavier Combelle added the

[issue25571] Improve the lltrace feature with the Py_Debug mode

Xavier Combelle added the comment: I made some comment on code in review. A thing that worry me that there is zero automated test. In my opinion the minimal should be to test the expected output. A nice to have would be a test for the write_contents function of makeopcodetranslations.py

[issue25571] Improve the lltrace feature with the Py_Debug mode

Changes by Stéphane Wirtel : -- components: +Interpreter Core versions: +Python 3.6 ___ Python tracker ___

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: here is the patch, if you want to test it, just use the REPL and add __ltrace__ = None in the REPL. -- Added file: http://bugs.python.org/file43747/issue25571-2.diff ___ Python tracker

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Here is a small example of lltrace when you enable it. ``` stephane@sg1 ~/s/h/cpython> ./python Python 3.6.0a3+ (default:0d8f139a6e19+, Jul 16 2016, 11:59:46) [GCC 6.1.1 20160621 (Red Hat 6.1.1-3)] on linux Type "help", "copyright", "credits" or "license"

[issue25571] Improve the lltrace feature with the Py_Debug mode

New submission from Stéphane Wirtel: When we use the Py_Debug flag for the compilation, we can see the Bytecodes and the opcode arguments. Here is a small patch, it will show the label of the opcode in the ceval.c file. -- messages: 254218 nosy: matrixise priority: normal severity:

[issue25571] Improve the lltrace feature with the Py_Debug mode

Stéphane Wirtel added the comment: Here is my patch with the improvement. -- keywords: +patch Added file: http://bugs.python.org/file40964/issue25571.patch ___ Python tracker