[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Serhiy Storchaka added the comment: New changeset b1dede3ee3498100b95265f7fdb0ea2bef9a2ba2 by Serhiy Storchaka in branch 'master': bpo-25750: Fix a compiler warning introduced in GH-9084. (GH-10234) https://github.com/python/cpython/commit/b1dede3ee3498100b95265f7fdb0ea2bef9a2ba2

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Serhiy Storchaka : -- pull_requests: +9857 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Jeroen Demeyer added the comment: > Is it necessary to use METH_FASTCALL? In Python 3, the bug only occurs with METH_FASTCALL. The issue is a reference counting bug and the temporary tuple used for a METH_VARARGS method avoids the bug. -- ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Serhiy Storchaka added the comment: Is it necessary to use METH_FASTCALL? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Serhiy Storchaka added the comment: bpo-33012 is about more strong warnings in gcc 8. This issue introduced a warning in gcc 7. -- ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: The cast warning is not specific to this issue, it's a more general issue that will be address in bpo-33012. I close again the bug. -- status: open -> closed ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: Comment on the commit: https://github.com/python/cpython/commit/5a30620e68ebb911eef4d583de3776d782148637#commitcomment-31057082 "bad_get should be explicitly cast to PyCFunction here, or else the compiler will balk; see https://bugs.python.org/msg328176 "

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Serhiy Storchaka added the comment: This change introduced a compiler warning. /home/serhiy/py/cpython/Modules/_testcapimodule.c:5042:17: warning: initialization from incompatible pointer type [-Wincompatible-pointer-types] {"bad_get", bad_get, METH_FASTCALL}, ^~~

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: New changeset 5a30620e68ebb911eef4d583de3776d782148637 by Victor Stinner (jdemeyer) in branch 'master': bpo-25750: Add test on bad descriptor __get__() (GH-9084) https://github.com/python/cpython/commit/5a30620e68ebb911eef4d583de3776d782148637 --

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Jeroen Demeyer : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: The bug has been fixed in 2.7, 3.6, 3.7 and master branches. Thanks Jeroen Demeyer for your tenacity and hard work :-) Let's see what we do with the unit test: PR 9084. -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: New changeset bf2bd8f8a1d88de60c114de957f50fe2433e3937 by Victor Stinner in branch '2.7': bpo-25750: fix refcounts in type_getattro() (GH-6118) (GH-9091) https://github.com/python/cpython/commit/bf2bd8f8a1d88de60c114de957f50fe2433e3937 --

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: New changeset 3ee07432f2e607cc6e7e6ea2d3695b672ceb1cea by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-25750: fix refcounts in type_getattro() (GH-6118) (GH-9088) https://github.com/python/cpython/commit/3ee07432f2e607cc6e7e6ea2d3695b672ceb1cea

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by STINNER Victor : -- pull_requests: +8549 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

miss-islington added the comment: New changeset f862f3abaed59b83763707ae529f0fe487961ba9 by Miss Islington (bot) in branch '3.7': bpo-25750: fix refcounts in type_getattro() (GH-6118) https://github.com/python/cpython/commit/f862f3abaed59b83763707ae529f0fe487961ba9 -- nosy:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by miss-islington : -- pull_requests: +8548 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by miss-islington : -- pull_requests: +8546 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by miss-islington : -- pull_requests: +8547 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: New changeset 8f735485acf2e35a75d2fa019feb8f905598c4e5 by Victor Stinner (jdemeyer) in branch 'master': bpo-25750: fix refcounts in type_getattro() (GH-6118) https://github.com/python/cpython/commit/8f735485acf2e35a75d2fa019feb8f905598c4e5 --

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Jeroen Demeyer : -- pull_requests: +8542 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Change by Roundup Robot : -- pull_requests: +5881 ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Claudio Freire added the comment: Nice ideas, will give them a try -- ___ Python tracker ___ ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Jeroen Demeyer added the comment: If you are on POSIX, you could also use cysignals to get a traceback (simply import cysignals, which will install a handler for fatal signals like SIGSEGV). -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: > The crash (the one we're experiencing) still happens with 2.7.13. But at this > point it's not clear whether it's a Python bug or a Cython bug, as jdemeyer's > patch doesn't fix it. We're having a hard time getting accurate backtraces to > actually debug

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Claudio Freire added the comment: The crash (the one we're experiencing) still happens with 2.7.13. But at this point it's not clear whether it's a Python bug or a Cython bug, as jdemeyer's patch doesn't fix it. We're having a hard time getting accurate backtraces to actually debug this

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: Claudio: "We're currently testing to try and reproduce the segfaults on 2.7.13, after that I'll try jdemeyer's patch and report the results." Cool! Keep us in touch ;-) -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

STINNER Victor added the comment: descr_ref-2.patch: patch rebased on the 2.7 branch. -- Added file: http://bugs.python.org/file46125/descr_ref-2.patch ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Claudio Freire added the comment: I cannot be 100% sure, but we have ample evidence suggesting we're experiencing this same crash in production. We have a big system that mixes Cython and pure-python coroutines, and in one version we started seeing segfaults that strongly hint at this root

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by Erik Bray : -- nosy: +erik.bray stage: -> patch review ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Stefan Behnel added the comment: I haven't seen any crashes in the wild here, but this is still the case in the latest code base. The change doesn't seem invasive, so I don't see why it shouldn't get implemented. -- nosy: +pitrou, scoder, serhiy.storchaka versions: +Python 3.5, Python

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by devurandom : -- nosy: +devurandom ___ Python tracker ___ ___ Python-bugs-list

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

François Bissey added the comment: Will Jeroen's patch make it into 2.7.12 or are you expecting more stuff before committing a change? -- nosy: +fbissey ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Armin Rigo added the comment: This is a known general issue which is documented in Lib/test/crashers/borrowed_ref_1 inside the 2.7 branch. In trunk, I see that this file has been deleted, although the issue has not been solved in general. Only the particular crash in the file has been

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Jeroen Demeyer added the comment: Thanks for the pointer. My patch does fix the crash in Lib/test/crashers/borrowed_ref_2.py on Python 2.7.10. -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by Jeroen Demeyer : -- type: -> crash ___ Python tracker ___ ___