[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

Changes by Christian Heimes : -- components: -SSL ___ Python tracker ___ ___

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

Changes by Christian Heimes : -- assignee: christian.heimes -> r.david.murray stage: needs patch -> patch review versions: +Python 2.7 -Python 3.5 ___ Python tracker

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

Changes by Christian Heimes : -- assignee: -> christian.heimes components: +SSL ___ Python tracker ___

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

gigaplastik added the comment: Here is the updated (3.6.0a4+) patch for the issue with the unit test included. My unit test only checks for this issue particular artifacts, it does not test that .starttls actually works. This is because the current test suite for smtplib

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

Christian Heimes added the comment: Please provide a more recent patch with a unit test. -- nosy: +christian.heimes stage: patch review -> needs patch versions: +Python 3.7 -Python 3.4 ___ Python tracker

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

gigaplastik added the comment: Found the same issue independently, but I believe my version of the patch is a little more thoughtful. Since the host is allowed to be supplied in 'hostname:port' format the assignment to ._host should be made _after_ checking (and probably parsing) this format.

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

Changes by R. David Murray : -- components: +email nosy: +barry, r.david.murray stage: -> patch review ___ Python tracker ___

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

SilentGhost added the comment: Here is a usable patch, there doesn't seem to be a test for starttls, but it's still would be a good idea to add a test for this issue. -- nosy: +SilentGhost versions: +Python 3.6 -Python 3.3 Added file: http://bugs.python.org/file41293/issue25852.diff

[issue25852] smtplib's SMTP.connect() should store the server name in ._host for .starttls()

New submission from W. Trevor King: With the current tip, starttls uses ._host when calling wrap_socket [1], but ._host is only setup in SMTP.__init__ [2]. Before #22921 [3] starttls would ignore ._host when SNI wasn't available locally. But as far as I can tell, starttls has never used