[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

Roundup Robot added the comment: New changeset 627575e9a7aa by Serhiy Storchaka in branch '3.5': Issue #25935: Garbage collector now breaks reference loops with OrderedDict. https://hg.python.org/cpython/rev/627575e9a7aa New changeset 5f0a08cfc4f6 by Serhiy Storchaka in branch 'default': Issue

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

Serhiy Storchaka added the comment: In some cases (as in committed test) garbage collector was not able to collect a loop with OrderedDict at all. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

Serhiy Storchaka added the comment: An OrderedDict owns two references to every key (as a dict and from a linked list). Therefore it should visit it twice in tp_traverse. Proposed patch fixes garbage collection for OrderedDict. It also rewrites OrderedDict clearing in more reentrant form (a

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

Changes by Berker Peksag : -- nosy: +eric.snow, serhiy.storchaka ___ Python tracker ___

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

Changes by Tim Graham : -- nosy: +Tim.Graham ___ Python tracker ___ ___

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

New submission from Simon Charette: I attached a file with a reproduction test case that passes on Python 2.7 and 3.4 but fails on 3.5.0 and 3.5.1 This might be solved by the improvement planed in #25410. -- components: Extension Modules files: test.py messages: 256945 nosy: charettes