[issue26076] redundant checks in tok_get in Parser\tokenizer.c

2016-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset f0acce8022d1 by Benjamin Peterson in branch 'default': remove duplicated check for fractions and complex numbers (closes #26076) https://hg.python.org/cpython/rev/f0acce8022d1 -- nosy: +python-dev resolution: -> fixed stage: patch review

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

2016-03-24 Thread Martin Panter
Martin Panter added the comment: The change looks pretty good to me. I guess some test cases could be added to Lib/test/test_grammar.py, unless there is somewhere else that already tests this sort of stuff. -- nosy: +martin.panter ___ Python

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

2016-03-24 Thread SilentGhost
SilentGhost added the comment: Could any one of the core developers have a look? Seems like a rather straightforward change. -- ___ Python tracker ___

[issue26076] redundant checks in tok_get in Parser\tokenizer.c

2016-01-10 Thread Oren Milman
Oren Milman added the comment: Sorry for being so clueless. The diff is attached. I manually did some checks to verify that relevant stuff work correctly (the imaginary number 0j, and fractions starting with '0.'). I run 'python -m test', and got the following output: 352 tests OK. 1 test