[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset 32518b439b9590cce0ef0639e558dc1ce2e152bb by Andrew Svetlov (Miss Islington (bot)) in branch '3.6': bpo-26133: Fix typos (GH-5010) (#5014) https://github.com/python/cpython/commit/32518b439b9590cce0ef0639e558dc1ce2e152bb

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset a8f4e15f3d33084862ddd3a7d58cd00034e94f16 by Andrew Svetlov in branch 'master': bpo-26133: Fix typos (#5010) https://github.com/python/cpython/commit/a8f4e15f3d33084862ddd3a7d58cd00034e94f16 --

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Roundup Robot : -- pull_requests: +4904 ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Andrew Svetlov : -- pull_requests: +4899 ___ Python tracker ___ ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 -Python 3.5 ___ Python tracker

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset 5ff5d1167de88eb37265dcaf1396d12617a0ace7 by Andrew Svetlov (Miss Islington (bot)) in branch '3.6': bpo-26133: Clear signals list on interpreter finalizing (GH-5002) (#5003)

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Roundup Robot : -- pull_requests: +4892 ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset 4f146f9ed133b9ad56d4ee7a653396836af34067 by Andrew Svetlov in branch 'master': bpo-26133: Clear signals list on interpreter finalizing (#5002)

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Andrew Svetlov : -- pull_requests: +4891 ___ Python tracker ___ ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset 3bc68cff5b821e83ee5df8b8cd13f4f54151b406 by Andrew Svetlov (Miss Islington (bot)) in branch '3.6': bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown (GH-4956) (#4962)

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Roundup Robot : -- pull_requests: +4853 ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: New changeset 4a02543cf97e8cbf9293741379f977b85531e4c2 by Andrew Svetlov in branch 'master': bpo-26133: Dont unsubscribe signals in UNIX even loop on interpreter shutdown (#4956)

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: Implemented PR 4956 following Victor's suggestion. -- ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Change by Andrew Svetlov : -- keywords: +patch pull_requests: +4848 stage: -> patch review ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

STINNER Victor added the comment: > `remove_signal_handler()` should do nothing if `sys.is_finalizing()` is true. I dislike this option. If you want to use sys.is_finalizing(), I would prefer to modify _UnixSelectorEventLoop.close() to not try to remove signal

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Yury Selivanov added the comment: > `remove_signal_handler()` should do nothing if `sys.is_finalizing()` is true. Probably a good idea. See also https://github.com/python/asyncio/pull/456. -- ___ Python tracker

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Andrew Svetlov added the comment: `remove_signal_handler()` should do nothing if `sys.is_finalizing()` is true. -- assignee: -> asvetlov nosy: +asvetlov ___ Python tracker

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Hans Lellelid added the comment: FWIW, I am experiencing the issue described here with Python 3.5.1. -- nosy: +Hans Lellelid ___ Python tracker ___

[issue26133] asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly

Changes by STINNER Victor : -- title: asyncio: ugly error related signal handler at exit if the loop is not closed explicitly -> asyncio: ugly error related to signal handlers at exit if the loop is not closed explicitly