[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Roundup Robot added the comment: New changeset 73f89182bb4d by Martin Panter in branch 'default': Issue #26136: Upgrade the generator_stop warning to DeprecationWarning https://hg.python.org/cpython/rev/73f89182bb4d -- nosy: +python-dev ___ Python

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Martin Panter added the comment: Thanks for your work Anish -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Anish Shah added the comment: @martin.panter Any reviews for the patch? Is it ready to merge? -- ___ Python tracker ___

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Martin Panter added the comment: Thanks for the updated patch. There are a couple minor problems with the What’s New entry, which you can fix if you want, or I could fix if I get around to merging it: * Bullet point should probably be wrapped onto multiple lines * According to the 3.5 What’s

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Anish Shah added the comment: @martin.panter I have fixed the What's New docs. I have updated the patch. Thanks! -- Added file: http://bugs.python.org/file41840/issue26136_20160207.patch ___ Python tracker

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Martin Panter added the comment: FYI I found that changeset by doing annotate on the file that you originally changed , which is an index of the changesets that last modified each line. Thanks for the patch, I think it

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Anish Shah added the comment: Thanks @martin.panter. I learnt something new, I didn't know about annotate before. I have updated the patch. Thanks again. -- Added file: http://bugs.python.org/file41800/issue26136_20160204.patch ___ Python tracker

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Anish Shah added the comment: Yes @martin.panter, the tests were failing. But, I didn't know where the tests for PendingDeprecationWarning were added. Thanks for telling the changeset. I have updated the patch. Can you please have a look? -- Added file:

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Martin Panter added the comment: Have you tried running the test suite? I suspect there are tests that will fail. E.g. the tests in revision 2771a0ac806b would need to be changed over to DeprecationWarning as well. -- stage: needs patch -> patch review

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Anish Shah added the comment: I have submitted a patch. I have replace `PyExc_PendingDeprecationWarning` to `PyExc_DeprecationWarning` in Objects/genobject.c Can anyone please review? -- keywords: +patch Added file: http://bugs.python.org/file41783/issue26136.patch

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti ___ Python tracker ___

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

New submission from Martin Panter: PEP 479 says “Python 3.6: Non-silent deprecation warning” if “StopIteration bubbles out of a generator not under __future__ import”. Currently I see a PendingDeprecationWarning in this case; I guess this should be changed to DeprecationWarning in the 3.6