[issue26209] TypeError in smtpd module with string arguments

Roundup Robot added the comment: New changeset 7aaf8cff23e5 by R David Murray in branch '2.7': #26209: Clarify type of *localaddr*/*remoteadr* in smtpd docs. https://hg.python.org/cpython/rev/7aaf8cff23e5 -- ___ Python tracker

[issue26209] TypeError in smtpd module with string arguments

Changes by R. David Murray : -- dependencies: -Deprecate smtpd (based on deprecated asyncore/asynchat): write a new smtp server with asyncio resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue26209] TypeError in smtpd module with string arguments

R. David Murray added the comment: Thanks for the patch, Ram. I started from your patch but further clarified exactly what the tuple is by linking to the actual documentation in the socket docs of what a (host, port) tuple looks like. I'll apply my patch to 2.7 as well as soon as I confirm

[issue26209] TypeError in smtpd module with string arguments

Roundup Robot added the comment: New changeset 1ed37f6e91bb by R David Murray in branch '3.5': #26209: Clarify type of *localaddr*/*remoteadr* in smtpd docs. https://hg.python.org/cpython/rev/1ed37f6e91bb New changeset fe2ca2216334 by R David Murray in branch 'default': Merge: #26209: Clarify

[issue26209] TypeError in smtpd module with string arguments

Ram Vallury added the comment: added space before word portnumber. column space adjusted -- Added file: http://bugs.python.org/file44055/smtpd_doc_updated_3.patch ___ Python tracker

[issue26209] TypeError in smtpd module with string arguments

Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker ___

[issue26209] TypeError in smtpd module with string arguments

Ram Vallury added the comment: Submitting patch 2 for smtpd doc changes -- Added file: http://bugs.python.org/file44047/smtpd_doc_updated_2.patch ___ Python tracker

[issue26209] TypeError in smtpd module with string arguments

Ram Vallury added the comment: Updated the documentation of smtpd. https://docs.python.org/3/library/smtpd.html#smtpserver-objects * this is my first patch, please revert back to me or make learn if I do any mistake* -- keywords: +patch nosy: +rvallury Added file:

[issue26209] TypeError in smtpd module with string arguments

Changes by Anish Shah : -- nosy: -anish.shah ___ Python tracker ___ ___

[issue26209] TypeError in smtpd module with string arguments

Changes by Anish Shah : -- nosy: +anish.shah ___ Python tracker ___ ___

[issue26209] TypeError in smtpd module with string arguments

Lorenzo Ancora added the comment: (msg259748) ok, then I propose to correct https://docs.python.org/dev/library/smtpd.html?highlight=q#smtpd.SMTPServer from: .. class:: SMTPServer(localaddr, remoteaddr, data_size_limit=33554432,\ map=None, enable_SMTPUTF8=False,

[issue26209] TypeError in smtpd module with string arguments

Terry J. Reedy added the comment: Note that the proposed code change would be a 3.6 only enhancement. Adding the other versions was part of changing to a doc-only issue. Note also that if the module is not deprecated, then a 3.6 code change could be considered. But only a doc change for

[issue26209] TypeError in smtpd module with string arguments

Terry J. Reedy added the comment: Code patches should not be assigned to 'docs'. But Berker, for the reason stated, thinks this should be doc only. Giampaolo is not currently active, so should not be assigned the issue by anyone else. After making a patch -- see the devguide -- use the

[issue26209] TypeError in smtpd module with string arguments

Lorenzo Ancora added the comment: (msg259475) Terry J. Reedy thank you for the correction, I've confused the versions affected with the versions actually supported. Since this doesn't only affect the documentation, is it correct to assign the issue to docs@python? The expert index indicates

[issue26209] TypeError in smtpd module with string arguments

Terry J. Reedy added the comment: Doc fixes unrelated to security fixes are not applied to security-fix-only versions. -- versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue26209] TypeError in smtpd module with string arguments

Lorenzo Ancora added the comment: (msg259229) Terry J. Reedy i Suggest that a standard and globally accepted scheme to manage IPv4 addresses is: "Host:PortNumber" --> (host, PortNumber) "Host"--> (host, DefaultPortNumber) "IP:PortNumber" --> (host, PortNumber) "IP"

[issue26209] TypeError in smtpd module with string arguments

Berker Peksag added the comment: There is a strong change that smtpd is going to be deprecated in Python 3.6. See issue 25008 for details. +1 for improving documentation. -- assignee: -> docs@python components: +Documentation -Library (Lib) keywords: +easy nosy: +berker.peksag,

[issue26209] TypeError in smtpd module with string arguments

Terry J. Reedy added the comment: I am guessing that 25 is the default port. Autoconversion of 'host' to ('host', 25) would be a new feature ('enhancement') that would have to wait for the next Python version (3.6 or later). Is there any precedent for this in any other module? Does 2.7 act

[issue26209] TypeError in smtpd module with string arguments

New submission from Lorenzo Ancora: smtpd.PureProxy(localaddr="host1", remoteaddr="host2") ...produces the error: [...] smtpd.py", line 657, in __init__ gai_results = socket.getaddrinfo(*localaddr, type=socket.SOCK_STREAM) TypeError: getaddrinfo() got multiple values for argument 'type'

[issue26209] TypeError in smtpd module with string arguments

Changes by SilentGhost : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___