Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
applied with r37952 (trunk), r37953 (2.6) and r37978 (py3k, docstrings
only). Thanks for the patch!
--
resolution: accepted - fixed
status: open - closed
___
Python tracker
Barry A. Warsaw ba...@python.org added the comment:
Looks good; feel free to commit.
--
versions: -Python 2.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2622
___
Barry A. Warsaw ba...@python.org added the comment:
The patch looks pretty good, except that you should not change
test_email.py. It specifically tests the old names, while
test_email_renamed.py tests the new names.
There's no point in fixing Python 2.5 since there won't be another
maintenance
Mads Kiilerich m...@kiilerich.com added the comment:
I have updated the patch. (Applied to 2.6 where it seems like some
casings had been fixed, so I dropped all the rejects. Changes to
test_email.py has been.)
--
Added file: http://bugs.python.org/file14352/emailcasings2.patch
John Jackson johnjack...@pobox.com added the comment:
Also occurs in 2.6...
--
versions: +Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2622
___
Zach Hirsch zhir...@umich.edu added the comment:
I'm not sure if this is the same problem, but it seems related. I can
get the same ImportError without involving py2exe or modulefinder:
Python 2.5.4 (r254:67916, Feb 18 2009, 03:00:47)
[GCC 4.3.3] on linux2
Type help, copyright, credits or
Mads Kiilerich [EMAIL PROTECTED] added the comment:
Testing that email.message doesn't use the wrong casing
email.Generator isn't enough. That would just test that this patch has
been applied. It must also be tested that no other modules uses the
wrong casing of email.Generator. Or other email
Mads Kiilerich [EMAIL PROTECTED] added the comment:
AFA I understand it the ImportError comes when running a py2exe/app'ed
package where iterators.py hasn't been included.
I was just about to file a report about (I think) the same issue, seen
on XP when py2exe'ing code using the email module.
Mads Kiilerich [EMAIL PROTECTED] added the comment:
This patch seems to fix the issue for me.
The easiest way to verify might be to create another patch and compare
them...
--
keywords: +patch
Added file: http://bugs.python.org/file10106/emailcasings.patch
Barry A. Warsaw [EMAIL PROTECTED] added the comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Apr 25, 2008, at 10:44 AM, Mads Kiilerich wrote:
Mads Kiilerich [EMAIL PROTECTED] added the comment:
This patch seems to fix the issue for me.
The easiest way to verify might be to
Mads Kiilerich [EMAIL PROTECTED] added the comment:
OK. I had assumed that backward compatibility was tested in the _renamed
tests, so that these tests one day could be dropped together with
backward compatibility. I didn't notice that my search'n'replaces showed
me that I was wrong.
But a
Amaury Forgeot d'Arc [EMAIL PROTECTED] added the comment:
But such a test doesn't belong in the test suite.
py2exe uses the modulefinder module to find dependencies.
I tried this command::
./python -m modulefinder Lib\email\message.py
And among the output, there is::
?
John Jackson [EMAIL PROTECTED] added the comment:
Attached is a sample code that reproduces the problem under python 2.5 on
Mac OS 10.4.11. See file for instructions on how to reproduce the issue.
Added file: http://bugs.python.org/file10030/test_mailbox.py
__
John Jackson [EMAIL PROTECTED] added the comment:
I'll put one together.
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2622
__
___
Python-bugs-list mailing list
Unsubscribe:
Guilherme Polo [EMAIL PROTECTED] added the comment:
You may not like the naming applied there, but surely it is not a import
error. Can you actually manage to get an ImportError ?
--
nosy: +gpolo
__
Tracker [EMAIL PROTECTED]
Changes by Georg Brandl [EMAIL PROTECTED]:
--
assignee: - barry
nosy: +barry
priority: - low
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2622
__
___
John Jackson [EMAIL PROTECTED] added the comment:
Yes. If the code is used to build a standalone application with py2app
on the Mac, here's the end of the stack trace:
File controller.pyo, line 17, in module
File readMail.pyo, line 15, in module
File mailbox.pyo, line 1294, in module
Guilherme Polo [EMAIL PROTECTED] added the comment:
Can you send a sample code that reproduces that ?
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2622
__
___
Python-bugs-list
New submission from John Jackson [EMAIL PROTECTED]:
In email.message.py there are two import errors:
line 128 from email.Generator import Generator
should be
from email.generator import Generator
line 784 from email.Iterators import walk
should be
from email.iterators import walk
19 matches
Mail list logo
