[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

miss-islington added the comment: New changeset d4128485d6c2cbfebe756f3eeec2c60137b63bba by Miss Islington (bot) in branch '3.10': bpo-26228: [doc] Adapt PTY documentation updates from GH-4167 (GH-27754) https://github.com/python/cpython/commit/d4128485d6c2cbfebe756f3eeec2c60137b63bba

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Łukasz Langa added the comment: New changeset dd8eb303b90d63e1f56684bedadca6674bb74a29 by Łukasz Langa in branch 'main': bpo-26228: [doc] Adapt PTY documentation updates from GH-4167 (GH-27754) https://github.com/python/cpython/commit/dd8eb303b90d63e1f56684bedadca6674bb74a29 --

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by miss-islington : -- pull_requests: +26233 pull_request: https://github.com/python/cpython/pull/27758 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by Łukasz Langa : -- pull_requests: +26230 pull_request: https://github.com/python/cpython/pull/27754 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Łukasz Langa added the comment: This is now merged. Thanks for all input, everyone! ✨  ✨ -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Łukasz Langa added the comment: New changeset 5d34ad4e1943a88c9d3aadd300fd0f05dab7 by Miss Islington (bot) in branch '3.10': bpo-26228: Fix pty EOF handling (GH-12049) (GH-27732) https://github.com/python/cpython/commit/5d34ad4e1943a88c9d3aadd300fd0f05dab7 --

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +26212 pull_request: https://github.com/python/cpython/pull/27732 ___ Python tracker

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by Łukasz Langa : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.5, Python 3.6 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Łukasz Langa added the comment: New changeset 81ab8db235580317edcb0e559cd4c983f70883f5 by Zephyr Shannon in branch 'main': bpo-26228: Fix pty EOF handling (GH-12049) https://github.com/python/cpython/commit/81ab8db235580317edcb0e559cd4c983f70883f5 -- nosy: +lukasz.langa

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by Soumendra Ganguly : -- pull_requests: +21879 pull_request: https://github.com/python/cpython/pull/22962 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by Soumendra Ganguly : -- title: pty.spawn hangs on FreeBSD 9.3, 10.x -> pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Soumendra Ganguly added the comment: Hi! Can anyone please take a look at https://bugs.python.org/issue41494 [ https://github.com/python/cpython/pull/21752 ]? I think these are related. I wrote a new function called wspawn, which is like spawn+the following differences. 1. It sets window

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Geoff Shannon added the comment: I'm aware of it. I actually wrote that patch as well. :D -- ___ Python tracker ___ ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

STINNER Victor added the comment: Please have a look at this pty.spawn() documentation change: https://github.com/python/cpython/pull/11980 -- ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Geoff Shannon added the comment: I took a shot at fixing this in a smaller more targeted patch. I think this should still solve the major issue of pty.spawn hanging on platforms that don't raise an error. In addition, pty.spawn should now _ALWAYS_ return the terminal to the previous

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Change by Geoff Shannon : -- pull_requests: +12074 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Jarry Shaw added the comment: Chris' patch works on macOS 10.14 (Mojave); but after it terminates, tty attributes are not restored (new-lines are missing). btw, I've implemented a workaround library with solution through either `ps` command or `psutil` package, see `ptyng` on PyPI.

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Martin Panter added the comment: If it helps, here is a basic test case I wrote for “pty.spawn”. I hope that it exposes the problem on Free BSD, but I have only tested it on Linux. parent = r'''\ import pty, sys pty.spawn((sys.executable, "-c", sys.argv[1])) ''' child =

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Change by Cornelius Diekmann : -- pull_requests: +4136 ___ Python tracker ___ ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Changes by Roundup Robot : -- pull_requests: +2984 ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

John Beck added the comment: Solaris has this problem also, and Chris' patch fixes it for us. -- nosy: +jbeck ___ Python tracker ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Martin Panter added the comment: Behaviour change in Free BSD as I understand. Nothing changed in Python, but perhaps older versions of Free BSD behaved like Linux and raised EIO (or another errno; it is not clear). -- ___ Python tracker

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

STINNER Victor added the comment: > That used to be true in FBSD, but then someone fixed (?) it, and now the > master side simply returns EOF when read-from. Is it a behaviour change in a new version of Python? Or a change in FreeBSD? I don't understand. --

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Cornelius Diekmann added the comment: I just tested pty.spawn() on OS X 10.6.8 and FreeBSD 11 and it also hangs. It works on Linux. Your patch solves the problem. I proposed a test suite for pty.spawn() in issue29070. The test suite currently only exposes the problem, as suggested by Martin.

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x

Martin Panter added the comment: I agree with all the changes you made. I made one review comment. It would be nice to add a test case to expose the problem. Correct me if I am wrong, but it doesn’t look like pty.spawn() is tested at all. FWIW on Linux, reading from the master end seems to