[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

Serhiy Storchaka added the comment: Thanks for your review. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

Roundup Robot added the comment: New changeset c7eff18f3840 by Serhiy Storchaka in branch 'default': Issue #26312: SystemError is now raised in all programming bugs with using https://hg.python.org/cpython/rev/c7eff18f3840 -- nosy: +python-dev ___ Pyt

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

Serhiy Storchaka added the comment: SystemError is not new exception. It could be raised on other programming bugs. In any case I doesn't expect that anybody catches such exceptions. -- ___ Python tracker

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

STINNER Victor added the comment: > The only question is whether there should be a "What's New?" entry for the > change. I don't think so. It's low level and nobody should see this exception anyway :-) It's an obvious bug in a C extension. -- ___ P

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

Jim Jewett added the comment: It feels a bit odd to say that I've performed a triage review given the three people already involved -- but I did, and I think it is ready to commit. I believe it is a bug fix, but too subtle a bug to justify backporting. The only question is whether there should

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

STINNER Victor added the comment: Yeah, I also expect SystemError from C functions (of the Python C API) badly used. RuntimeError is more used in programming bugs at Python level. pyarg_parse_error.patch LGTM. -- nosy: +haypo ___ Python tracker

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

Martin Panter added the comment: Seems like a reasonable change and patch to me. -- nosy: +martin.panter ___ Python tracker ___ ___ Py

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

New submission from Serhiy Storchaka: For now programmical errors with the use of PyArg_ParseTuple() cause raising SystemError. But some programmical errors with the use of PyArg_ParseTupleAndKeywords() cause raising RuntimeError. I think that SystemError is the correct exception type. Propos