[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Roundup Robot added the comment: New changeset 3275d4b584a2 by Benjamin Peterson in branch '3.6': remove comment about updating the parser module; we do not need to do that anymore (#26526) https://hg.python.org/cpython/rev/3275d4b584a2 -- ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

A. Skrobov added the comment: Oh btw, the comment in the beginning of Grammar/Grammar > # Note: Changing the grammar specified in this file will most likely > #require corresponding changes in the parser module > #(../Modules/parsermodule.c). is no longer true: after this

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

A. Skrobov added the comment: Thanks Xavier! Yes, this is the same DFA that's used by the main Python parser. For some reason, parsermodule didn't previously reuse it, but instead did its own thing. Any volunteers to review the other patch for Python parser, at

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Xavier Combelle added the comment: The DFA is generated by other part of existing cpython code ? If it's the case looks like you did a great job. -- nosy: +xcombelle ___ Python tracker

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Roundup Robot added the comment: New changeset 4a9159ea2536 by Benjamin Peterson in branch 'default': replace custom validation logic in the parse module with a simple DFA validator (closes #26526) https://hg.python.org/cpython/rev/4a9159ea2536 -- nosy: +python-dev resolution: ->

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Brett Cannon added the comment: Are you up for trying to commit this while at the sprints, Fred? If not then assign it back to me and I can eventually commit it (busy w/ a ton of stuff so I can't promise when I will get to it). -- assignee: -> fdrake stage: patch review -> commit

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by A. Skrobov : -- keywords: +patch Added file: http://bugs.python.org/file43069/issue26526_16704_63395.diff ___ Python tracker

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

A. Skrobov added the comment: Thank you Fred for your review! I don't have commit access myself; can anybody please commit it for me? -- ___ Python tracker

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Fred L. Drake, Jr. added the comment: I've read through this, but haven't applied the patch & run tests (that's what buildbots are for). No objections. -- ___ Python tracker

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Fred L. Drake, Jr. added the comment: I see your message to python-dev, and apologize for taking so long to get to this. I do intend to read through your changes, and hope to be able to make time while I'm at PyCon this coming week. -- ___ Python

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

A. Skrobov added the comment: Ping? This patch is two months old now. -- ___ Python tracker ___ ___

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

Changes by STINNER Victor : -- title: In parsemodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA -> In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA ___ Python tracker