[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-10-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset d76fccbad014 by Martin Panter in branch '3.5': Issue #26620: Fix ResourceWarning in test_urllib2_localnet https://hg.python.org/cpython/rev/d76fccbad014 -- ___ Python tracker

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-24 Thread Martin Panter
Martin Panter added the comment: This handling of KeyboardInterrupt seems like a bug with unittest IMO. But personally I don’t spend too much thought or code handling KeyboardInterrupt in tests, for similar reasons to not doing special handling of test failures in Issue 26612. --

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-24 Thread STINNER Victor
STINNER Victor added the comment: Martin wrote: > This patch looks okay to me. I left one review suggestion. Thanks for the review, I changed this code. While testing one more time my patch with CTRL+c, I noticed that sometimes the servers are not stopped properly and os.environ is not

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-24 Thread Roundup Robot
Roundup Robot added the comment: New changeset 54d7e9919876 by Victor Stinner in branch 'default': Closes #26620: Fix ResourceWarning in test_urllib2_localnet https://hg.python.org/cpython/rev/54d7e9919876 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open ->

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-23 Thread Martin Panter
Martin Panter added the comment: This patch looks okay to me. I left one review suggestion. Focussing on test_sending_headers(), the ResourceWarning seems to be only shown since revision 46329eec5515 (Issue 26590). In simpler cases, the warning would be bypassed due to Issue 19829. But in

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-23 Thread STINNER Victor
New submission from STINNER Victor: Attached patch fixes 3 ResourceWarning warnings in Lib/test/test_urllib2_localnet.py. See also issue #26612 (test_ssl). Example of warning logged by "./python -X tracemalloc=25 -m test -v test_urllib2_localnet ": ---

[issue26620] Fix ResourceWarning warnings in test_urllib2_localnet

2016-03-23 Thread STINNER Victor
Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file42257/test_urllib2_localnet.patch ___ Python tracker