[issue26664] find a bug in activate.fish of venv of cpython3.6

Xiang Zhang added the comment: I get the same feeling. Add Larry. -- nosy: +larry ___ Python tracker ___ ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

erdban fed added the comment: This bug shipped in 3.5.2. It should've been a blocker. -- nosy: +erdban fed ___ Python tracker ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Xiang Zhang added the comment: The patch introduced by issue26348 should be reverted. The __VENV_PROMPT__ is meant to be a placeholder. For example, when you create a virtual environment named venv-test, the __VENV_PROPMT__ will be replace by (venv-test). If the patch is applied, it will be

[issue26664] find a bug in activate.fish of venv of cpython3.6

Tin Tvrtković added the comment: Also I will add I've been using fish for a long time and have never been affected by #26348. -- ___ Python tracker ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by Tin Tvrtković : -- versions: +Python 3.5 ___ Python tracker ___ ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Tin Tvrtković added the comment: I'm getting this exact issue on Python 3.5 (xenial system installation). All my existing venvs (from before my upgrade to xenial) work. Here's the diff: > diff .venv/bin/activate.fish ../wrapt/.venv/bin/activate.fish 35c35 < set -gx VIRTUAL_ENV

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Vinay Sajip added the comment: I've asked the person who sent in the patch for #26348 to comment on this issue. -- ___ Python tracker ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

鄭景文 added the comment: First, I use python 3.5.1 to create virtual environment. It works fine with fish. There is no $ in the activate.fish file. Second, after I removed the $, It works fine, both in ubuntu and arch linux. I guess it is because the $ is for bash not for fish, the activate.fish

[issue26664] find a bug in activate.fish of venv of cpython3.6

Vinay Sajip added the comment: The change you mention was in response to Issue #26348. The patch supplied there introduced the $ characters you say aren't required. I'm not a fish user, but it would seem that "$__VENV_PROMPT__" would resolve to the *value* of the environment variable

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by SilentGhost : -- nosy: +vinay.sajip ___ Python tracker ___ ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by 鄭景文 : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list

[issue26664] find a bug in activate.fish of venv of cpython3.6

Changes by 鄭景文 : -- components: +Library (Lib) versions: +Python 3.6 ___ Python tracker ___

[issue26664] find a bug in activate.fish of venv of cpython3.6

New submission from 鄭景文: I use venv module to make a virtual environment in cpython3.6. After it, I try to activate it with fish, but it give me an error, like the screenshot. I open the activate.fish and remove the $ sign in line 58 and 59, then the activate file works. I open the