[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

STINNER Victor added the comment: Python 2 users have this bug since 2010, I think that it's fine to not fix it. Python 2 support ends at the end of the year. I close the issue. The issue has been fixed in Python 3.6 and newer. -- resolution: -> fixed stage: patch review ->

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Batuhan added the comment: Victor's PR 11507 is closed, what actions are going to be taken next? Close the issue as Mariatta said? -- nosy: +BTaskaya ___ Python tracker ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

STINNER Victor added the comment: I wrote PR 11507 to raise ValueError rather than OverflowError for -inf and +inf. -- ___ Python tracker ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Change by STINNER Victor : -- pull_requests: +11049, 11050, 11051 stage: backport needed -> patch review ___ Python tracker ___ ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Change by STINNER Victor : -- pull_requests: +11049, 11050, 11051, 11052 stage: backport needed -> patch review ___ Python tracker ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Change by STINNER Victor : -- pull_requests: +11049, 11050 stage: backport needed -> patch review ___ Python tracker ___ ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Change by STINNER Victor : -- pull_requests: +11049 stage: backport needed -> patch review ___ Python tracker ___ ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Mariatta Wijaya added the comment: This has been backported to 3.6. Is backport to 2.7 needed? If not we'll close the issue. -- stage: patch review -> backport needed ___ Python tracker

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Mariatta Wijaya added the comment: New changeset a4baf1c543bca261c27e98ba296e42665f3cb872 by Mariatta (Miss Islington (bot)) in branch '3.6': [3.6] bpo-26669: Fix nan arg value error in pytime.c (GH-3085) (GH-3467)

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

STINNER Victor added the comment: For Python 2.7, you have at least to fix these 2 functions: parse_time_double_args(), _PyTime_DoubleToTimet(). -- ___ Python tracker

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Changes by Roundup Robot : -- keywords: +patch pull_requests: +3460 stage: needs patch -> patch review ___ Python tracker

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

STINNER Victor added the comment: New changeset 829dacce4fca60fc3c3367980e75e21dfcdbe6be by Victor Stinner (Han Lee) in branch 'master': bpo-26669: Fix nan arg value error in pytime.c (#3085) https://github.com/python/cpython/commit/829dacce4fca60fc3c3367980e75e21dfcdbe6be --

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

STINNER Victor added the comment: I like PR 3085 to raise explicitly a ValueError with an helpful error message. -- nosy: +haypo ___ Python tracker ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Mark Dickinson added the comment: > potentially questionable? I'll ask a C compiler person... Questionable indeed. Attempting to cast a NaN to an integer type results in undefined behaviour. Unfortunately, so does attempting to cast any double value that's outside the range represented by the

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Changes by Roundup Robot : -- pull_requests: +3127 ___ Python tracker ___

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

Changes by Alexander Belopolsky : -- assignee: -> belopolsky nosy: +belopolsky stage: -> needs patch type: -> behavior ___ Python tracker

[issue26669] time.localtime(float("NaN")) does not raise a ValueError on all platforms

New submission from Gregory P. Smith: time.localtime(float("NaN")) raises a ValueError on x86_64 using the few compilers I have tested it with. (this makes sense) >>> time.localtime(float("NaN")) Traceback (most recent call last): File "", line 1, in ValueError: (75, 'Value too large for