[issue26920] android: test_sys fails

Changes by Donald Stufft : -- pull_requests: +908 ___ Python tracker ___ ___

[issue26920] android: test_sys fails

Changes by Xavier de Gaye : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue26920] android: test_sys fails

Roundup Robot added the comment: New changeset 73bd65e2 by Xavier de Gaye in branch '3.6': Issue #26920: Fix not getting the locale's charset upon initializing the interpreter, https://hg.python.org/cpython/rev/73bd65e2 New changeset f358d849c14e by Xavier de Gaye in branch 'default':

[issue26920] android: test_sys fails

Changes by Xavier de Gaye : -- assignee: -> xdegaye components: +Interpreter Core -Cross-Build, Extension Modules stage: -> commit review versions: +Python 3.7 ___ Python tracker

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: For the record, on the Android emulator we have now (not sure where this change has been made): >>> sys.getfilesystemencoding() 'utf-8' >>> locale.getpreferredencoding(False) 'ascii' So test_ioencoding_nonascii succeeds now. Anyway the problem with this test

[issue26920] android: test_sys fails

STINNER Victor added the comment: test_c_locale_surrogateescape.patch LGTM. -- ___ Python tracker ___ ___

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: With Serhiy's latest patch named sys_test_ioencoding.patch in issue19058, test_sys fails only in test_c_locale_surrogateescape on the android-21-x86 emulator. -- ___ Python tracker

[issue26920] android: test_sys fails

Serhiy Storchaka added the comment: See also issue19058. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: This patch fixes the locale setting on startup when the LC_ALL environment variable is set to C, and as a consequence test_c_locale_surrogateescape does not fail anymore. Note that on Android HAVE_LANGINFO_H is undefined, see issue #22747. -- Added

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: About the failures in test_c_locale_surrogateescape, it seems that on Android the locale is not set correctly on startup when LC_ALL is set to C: root@generic_x86:/data/local/tmp # LC_ALL=C python Python 3.6.0a0 (default:eee959fee5f5+, May 14 2016, 10:19:09)

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: This patch fixes test_ioencoding_nonascii. -- keywords: +patch Added file: http://bugs.python.org/file42844/test_ioencoding_nonascii.patch ___ Python tracker

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: > On Android, os.fsdecode(os.fsencode('\xe6')) does not raise UnicodeError in > the test.support module. Because of changeset ad6be34ce8c9. -- ___ Python tracker

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: > test_ioencoding_nonascii does not fail when LANG is set to en_GB.UTF-8 in the > environment. When LANG is not set, we have on an android emulator: >>> from test.support import FS_NONASCII >>> print(FS_NONASCII) Traceback (most recent call last): File "",

[issue26920] android: test_sys fails

Xavier de Gaye added the comment: test_ioencoding_nonascii does not fail when LANG is set to en_GB.UTF-8 in the environment. -- ___ Python tracker ___

[issue26920] android: test_sys fails

New submission from Xavier de Gaye: test_sys fails on an android emulator running an x86 system image at API level 21. ... test_implementation (test.test_sys.SysModuleTest) ... ok test_intern (test.test_sys.SysModuleTest) ... ok test_ioencoding (test.test_sys.SysModuleTest) ... ok