[issue26944] android: test_posix fails

Changes by Xavier de Gaye : -- dependencies: -add the 'is_android' attribute to test.support ___ Python tracker ___

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: Thanks for the patch David, see my comment in Rietveld. New patch based on David patch, just a bit simpler. -- stage: patch review -> commit review versions: +Python 3.7 Added file: http://bugs.python.org/file45067/test_getgroups_4.patch

[issue26944] android: test_posix fails

Changes by R. David Murray : -- stage: commit review -> patch review ___ Python tracker ___

[issue26944] android: test_posix fails

R. David Murray added the comment: Haypo: we are testing that our function wrapper (getgroups) returns something that we can parse as matching the results from the 'id' command. This gives us a much more meaningful test than just testing that getgroups returns *something*. That is, we are

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: The test is already skipped by the patch, for Android API level < 23, with the statement: raise unittest.SkipTest("need working 'id -G'") Do you mean that the test should be skipped instead more explicitly with something like:

[issue26944] android: test_posix fails

STINNER Victor added the comment: Ooops, I missed the part where you say that it works on API level >= 23. So I suggest to only skip the test on Android API level < 23. -- ___ Python tracker

[issue26944] android: test_posix fails

STINNER Victor added the comment: Sorry but I don't see the point of trying to "fix" the unit test on Android if "id -G" doesn't work as expected. In fact, I don't really understand the point of such functional test. Are we still testing Python? Or are we testing the OS itself? I suggest to

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: > Hum, does the id program supports -G on Android? It does on Android 6.0 but prints the same result as 'id' (without -G) on previous Android versions. Here is the output of the commands involved in the test for the root user on my archlinux box, the Android

[issue26944] android: test_posix fails

STINNER Victor added the comment: > ValueError: invalid literal for int() with base 10: 'uid=0(root)' Hum, does the id program supports -G on Android? The output looks like the regular id output (without -G). Example on my Linux (Fedora 24): $ id uid=1000(haypo) gid=1000(haypo)

[issue26944] android: test_posix fails

Changes by Xavier de Gaye : -- nosy: +haypo stage: patch review -> commit review ___ Python tracker ___

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: > Is there a plan to make Android a supported platform in 3.6? Answer in the Android meta-issue at msg 270942. -- ___ Python tracker

[issue26944] android: test_posix fails

Larry Hastings added the comment: Is there a plan to make Android a supported platform in 3.6? -- ___ Python tracker ___

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: New patch with cosmetic changes. -- assignee: -> xdegaye stage: -> patch review Added file: http://bugs.python.org/file43817/test_getgroups_2.patch ___ Python tracker

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: test_getgroups is ok on an android emulator running API 23 with the attached patch, and the test is skipped when running API 21. -- dependencies: +add is_android in test.support to detect Android platform -android: add platform.android_ver() keywords:

[issue26944] android: test_posix fails

Xavier de Gaye added the comment: 'id -G' produces the expected result on an android-23-x86 emulator running Android 6.0 (API 23). There is a new error now instead of the one reported at issue #26932: == FAIL: test_getgroups

[issue26944] android: test_posix fails

Serhiy Storchaka added the comment: See more information in comments in issue26932. Since the id tool looks fixed in Android 6.x we should skip the test on Android <6.x. -- components: +Tests -Cross-Build, Library (Lib) dependencies: +android: add platform.android_ver() nosy:

[issue26944] android: test_posix fails

New submission from Xavier de Gaye: test_posix fails on an android emulator running an x86 system image at API level 21. On android we have instead of a list of group IDs: root@generic_x86:/data/local/tmp # id -G uid=0(root) gid=0(root)