[issue27106] configparser.__all__ is incomplete

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue27106] configparser.__all__ is incomplete

Roundup Robot added the comment: New changeset 739528288996 by Martin Panter in branch 'default': Issue #27106: Add test for configparser.__all__ https://hg.python.org/cpython/rev/739528288996 -- nosy: +python-dev ___ Python tracker

[issue27106] configparser.__all__ is incomplete

Jacek Kołodziej added the comment: That's completely fine for me. I'm attaching the patch that just adds test for __all__, then. :) -- Added file: http://bugs.python.org/file44393/configparser_all.v2.patch ___ Python tracker

[issue27106] configparser.__all__ is incomplete

Łukasz Langa added the comment: I'm still not convinced this change is *useful*. The list of incompatibilities in Python 3.6 in whatsnew is going to be used retrospectively by people already affected by a production issue, googling for an explanation as to what went wrong. I like the idea of

[issue27106] configparser.__all__ is incomplete

Jacek Kołodziej added the comment: Łukasz, Martin - I'm not sure how to proceed here, of course both ways out are reasonable. I'd be happy to provide (however small) patch for either one (adding Error to __all__ or just adding test for __all__). :) My inner librarian would of course either

[issue27106] configparser.__all__ is incomplete

Martin Panter added the comment: My personal opinion is to include all public APIs. Names that are omitted from __all__ may not come up in pydoc, and it is surprising when I use “import * ” in the interactive interpreter to play with a module and there is something missing. To mitigate the

[issue27106] configparser.__all__ is incomplete

Łukasz Langa added the comment: The reason we specifically omitted Error was two-fold: - the name "Error" is very generic and during a star-import might easily shadow some other class of the same name; - Error is only a base class for exceptions raised by configparser and as such isn't part of

[issue27106] configparser.__all__ is incomplete

Martin Panter added the comment: Looks good to me -- nosy: +martin.panter stage: -> patch review ___ Python tracker ___

[issue27106] configparser.__all__ is incomplete

Changes by Serhiy Storchaka : -- nosy: +lukasz.langa ___ Python tracker ___ ___

[issue27106] configparser.__all__ is incomplete

New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing configparser module's __all__ list. -- components: Library (Lib) files: configparser_all.patch keywords: patch messages: 266266 nosy: Unit03 priority: normal severity: normal status: