[issue27108] mimetypes.__all__ list is incomplete

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue27108] mimetypes.__all__ list is incomplete

Roundup Robot added the comment: New changeset 2057b0af1c52 by Martin Panter in branch 'default': Issue #27108: Add missing names to mimetypes.__all__, by Jacek Kołodziej https://hg.python.org/cpython/rev/2057b0af1c52 -- nosy: +python-dev ___ Python

[issue27108] mimetypes.__all__ list is incomplete

R. David Murray added the comment: I thought having the empty blacklist was a good reminder, in case names are added later that need blacklisting (though granted that should be unlikely at this point, since we are more consistent about using _ names for internals now). I have no objection to

[issue27108] mimetypes.__all__ list is incomplete

Jacek Kołodziej added the comment: Thank you, Martin. I'm uploading amended patch. -- Added file: http://bugs.python.org/file42988/mimetypes_all.v2.patch ___ Python tracker

[issue27108] mimetypes.__all__ list is incomplete

Martin Panter added the comment: I left a comment about the empty blacklist. Other than removing the blacklist parameter, I think this is good to go. -- nosy: +martin.panter stage: -> commit review ___ Python tracker

[issue27108] mimetypes.__all__ list is incomplete

R. David Murray added the comment: LGTM -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list

[issue27108] mimetypes.__all__ list is incomplete

New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing mimetypes module's __all__ list. -- components: Library (Lib) files: mimetypes_all.patch keywords: patch messages: 266268 nosy: Unit03 priority: normal severity: normal status: open