[issue27111] redundant variables in long_add and long_sub

2016-09-17 Thread Mark Dickinson
Changes by Mark Dickinson : -- assignee: -> mark.dickinson ___ Python tracker ___ ___

[issue27111] redundant variables in long_add and long_sub

2016-09-17 Thread Mark Dickinson
Mark Dickinson added the comment: Applied; thanks. (I left the braces in, following PEP 7 ("braces are strongly preferred"). -- nosy: +mark.dickinson resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27111] redundant variables in long_add and long_sub

2016-09-17 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0e585bce0bb1 by Mark Dickinson in branch 'default': Issue #27111: Minor simplication to long_add and long_sub fast path code. Thanks Oren Milman. https://hg.python.org/cpython/rev/0e585bce0bb1 -- nosy: +python-dev

[issue27111] redundant variables in long_add and long_sub

2016-09-13 Thread Oren Milman
Changes by Oren Milman : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___ ___

[issue27111] redundant variables in long_add and long_sub

2016-06-05 Thread Oren Milman
Oren Milman added the comment: done. By the way, I am logging in to bugs.python.org through accounts.google.com, but I couldn't see any way to do the same in www.python.org, so I have a native account there (with the same email address). I hope that won't be an issue... --

[issue27111] redundant variables in long_add and long_sub

2016-06-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oren, could you please sign a Contributor Licensing Agreement? http://www.python.org/psf/contrib/contrib-form/ http://www.python.org/psf/contrib/ -- ___ Python tracker

[issue27111] redundant variables in long_add and long_sub

2016-05-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> patch review ___ Python tracker ___

[issue27111] redundant variables in long_add and long_sub

2016-05-24 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file42975/CPythonTestOutput.txt ___ Python tracker ___

[issue27111] redundant variables in long_add and long_sub

2016-05-24 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file42974/patchedCPythonTestOutput.txt ___ Python tracker ___

[issue27111] redundant variables in long_add and long_sub

2016-05-24 Thread Oren Milman
New submission from Oren Milman: the proposed changes In Objects/longobject.c in long_add and long_sub, the variables 'result' and 'r' (respectively), are used only once, and don't seem to make the code any clearer. It seems the 'result' and 'r' variables were added