[issue27141] Fix collections.UserList shallow copy

2020-10-10 Thread Bar Harel
Change by Bar Harel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27141] Fix collections.UserList shallow copy

2020-10-08 Thread Irit Katriel
Irit Katriel added the comment: This seems complete, can it be closed? -- nosy: +iritkatriel ___ Python tracker ___ ___

[issue27141] Fix collections.UserList shallow copy

2019-05-19 Thread miss-islington
miss-islington added the comment: New changeset 3645d29a1dc2102fdb0f5f0c0129ff2295bcd768 by Miss Islington (bot) in branch '3.7': bpo-27141: Fix collections.UserList and UserDict shallow copy. (GH-4094) https://github.com/python/cpython/commit/3645d29a1dc2102fdb0f5f0c0129ff2295bcd768

[issue27141] Fix collections.UserList shallow copy

2019-05-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +1 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27141] Fix collections.UserList shallow copy

2019-05-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f4e1babf44792bdeb0c01da96821ba0800a51fd8 by Serhiy Storchaka (Bar Harel) in branch 'master': bpo-27141: Fix collections.UserList and UserDict shallow copy. (GH-4094)

[issue27141] Fix collections.UserList shallow copy

2017-10-24 Thread Bar Harel
Bar Harel added the comment: Alrighty then, opt1 passed all tests and waiting on GitHub for inclusion :-) -- ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2017-10-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Either of the patches looks fine. I lean a bit towards the opt1 patch. -- assignee: rhettinger -> serhiy.storchaka ___ Python tracker

[issue27141] Fix collections.UserList shallow copy

2017-10-23 Thread Bar Harel
Bar Harel added the comment: Done :-) Seems like I forgot to edit the news though, I'll try to edit it. -- ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2017-10-23 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4065 stage: needs patch -> patch review ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2017-10-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I prefer issue27141_patch_rev1_opt1.patch. But now we use GitHub. Do you mind to create a pull request Bar? -- stage: -> needs patch versions: -Python 3.2, Python 3.3, Python 3.4, Python 3.5

[issue27141] Fix collections.UserList shallow copy

2016-10-13 Thread Bar Harel
Bar Harel added the comment: Bumposaurus Rex -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27141] Fix collections.UserList shallow copy

2016-09-26 Thread Bar Harel
Bar Harel added the comment: I personally prefer the __copy__ mechanism as I think a bugfix shouldn't be 10% backwards compatible, chances of issues are low, and it's cleaner, more efficient and how things should be. -- ___ Python tracker

[issue27141] Fix collections.UserList shallow copy

2016-09-26 Thread Bar Harel
Changes by Bar Harel : Added file: http://bugs.python.org/file44833/issue27141_patch_rev1_opt2.patch ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2016-09-26 Thread Bar Harel
Bar Harel added the comment: Alright. 2 patches are available. opt_1 makes the use of __copy__. Advantages: - Clean - Does not affect pickling at all - More memory efficient Disadvantages: - Might be missing something from the normal copy mechanism (e.g. UserList doesn't implement

[issue27141] Fix collections.UserList shallow copy

2016-09-25 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: UserList.copy() doesn't copy instance attributes, but copy.copy() should copy them. -- ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2016-09-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Yes. I will look at this shortly. -- ___ Python tracker ___ ___

[issue27141] Fix collections.UserList shallow copy

2016-07-02 Thread Pascal Chambon
Changes by Pascal Chambon : -- nosy: +pakal ___ Python tracker ___ ___

[issue27141] Fix collections.UserList shallow copy

2016-06-28 Thread Bar Harel
Bar Harel added the comment: Are the patch and tests good? -- ___ Python tracker ___ ___ Python-bugs-list

[issue27141] Fix collections.UserList shallow copy

2016-05-28 Thread Bar Harel
Bar Harel added the comment: Added UserDict and UserList tests. Keep in mind I am currently skipping UserDict's tests until we will implement the correct mechanism. We do not need the same tests or functionality for UserString as UserString is immutable. -- Added file:

[issue27141] Fix collections.UserList shallow copy

2016-05-28 Thread Bar Harel
Bar Harel added the comment: I thought about UserDict, but adding this simple patch to UserDict will result in infinite recursion (due to how copy is implemented in there). We will have to change the implementation of UserDict's copy method. -- ___

[issue27141] Fix collections.UserList shallow copy

2016-05-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What about UserDict? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2016-05-27 Thread Raymond Hettinger
Raymond Hettinger added the comment: Please add a test case. -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___

[issue27141] Fix collections.UserList shallow copy

2016-05-27 Thread Bar Harel
New submission from Bar Harel: I have encountered a weird behavior in collections.UserList. Using copy.copy() on an instance results in a new instance of UserList but with the same underlying list. Seems like self.copy() works great but __copy__ was not overridden to allow copy.copy to work