[issue27172] Undeprecate inspect.getfullargspec()

Change by Nick Coghlan : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27172] Undeprecate inspect.getfullargspec()

Change by Nick Coghlan : -- assignee: ncoghlan -> ___ Python tracker ___ ___

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Independently of what we eventually decide to do for 4.0, there are some changes we could make at the documentation level to more clearly indicate "Even though this isn't deprecated, you still shouldn't use it for new code":

[issue27172] Undeprecate inspect.getfullargspec()

Brett Cannon added the comment: I'm not saying we remove getfullargspec() **right now**, just that we don't keep it around long-term as it simply can't evolve to keep up with how rich our parameter support is today and might become in the future. And that's why, for me, the

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: I'll also note that one possible alternative would be to accept Ryan's original proposal, which was to make "skip_bound_arg=False" part of the public API for `inspect.Signature.from_callable`. Keeping `getfullargspec` around (but

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: If there was a documented deprecation that said "Use instead", I'd be OK with that. The part I wasn't OK with is multiple projects each copying & pasting their own variant of the getfullargspec code and accessing private inspect module

[issue27172] Undeprecate inspect.getfullargspec()

Brett Cannon added the comment: Nick pointed me at this issue for the undeprecation of inspect.getfullargspec(). While I'm fine with the un-deprecation for compatibility reasons, I would rather the function not last beyond Python 3 un-deprecated. Nick says, though that: """

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Note: the minor incompatibility that required getfullargspec() to be a separate API in the first place is the fact that it returns a 7 element named tuple instead of a 4 element one. This means that hybrid 2/3 code needs to consistently use

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Larry, your personal insult is entirely unwelcome, unnecessary, and unappreciated, especially as it's wrong regarding the Python 2/3 compatibility concerns. While getfullargspec() is indeed new in Python 3.x, it's also deliberately

[issue27172] Undeprecate inspect.getfullargspec()

Tim Graham added the comment: Perhaps the reason for the undeprecation could use some clarification. In a Python 3 only world (where Django's master branch is), I believe there's still usefulness for inspect.getfullargspec() -- see

[issue27172] Undeprecate inspect.getfullargspec()

Larry Hastings added the comment: Wait, what is all this nonsense? inspect.getfullargspec is Python 3 only. It was added to support keyword-only parameters. Python 2 doesn't *have* keyword-only parameters, so it isn't needed there. Check for yourself: Python 2 doesn't

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Oops, we/I missed the window for also getting the deprecation removed from 3.5.x (as that branch is now in security-fix only mode). Marking as resolved for 3.6 accordingly. -- resolution: -> fixed stage: backport needed -> resolved

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Also, note that the programmatic deprecation warning change in the patch is to the warning for `getargspec()`, so that it recommends `getfullargspec()` rather than `Signature()`. There's no runtime deprecation warning for `getfullargspec()` in any version of

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: No, there are no plans to ever deprecate getfullargspec() again - it isn't hard to maintain indefinitely as a wrapper around inspect.Signature(), and it doesn't have the significant limitations that affected getargspec(). -- priority: deferred blocker

[issue27172] Undeprecate inspect.getfullargspec()

Tim Graham added the comment: Does it seems likely that getfullargspec() will be deprecated after Python 2 is EOL? Django is currently reimplementing getargspec(): https://github.com/django/django/blob/8ab7ce8558792f41637d6f87f2a8a117e169dd18/django/utils/inspect.py#L4-L24 A pull request

[issue27172] Undeprecate inspect.getfullargspec()

Changes by Serhiy Storchaka : -- pull_requests: -923 ___ Python tracker ___ ___

[issue27172] Undeprecate inspect.getfullargspec()

Changes by Donald Stufft : -- pull_requests: +923 ___ Python tracker ___ ___

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Thank you Serhiy! That leaves this just as a pending update for 3.5.3 to bring it into line with 3.6.0. I've reverted the stage to "needs patch" and removed the patch keyword, as the 3.5 patch will be slightly different: - using 3.5.3 in the versionchanged

[issue27172] Undeprecate inspect.getfullargspec()

Ned Deily added the comment: It looks like Serhiy took care of the merge to default in dd4c420b8e66. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: I've pushed the change for 3.6.0rc1 based on Yury and Martin's review, but wasn't able to forward merge it to default due to merge conflicts on Misc/NEWS that I wasn't sure how to resolve. -- priority: release blocker -> deferred blocker stage: needs

[issue27172] Undeprecate inspect.getfullargspec()

Roundup Robot added the comment: New changeset 14c2d93ffcb3 by Nick Coghlan in branch '3.6': Issue #27172: Undeprecate inspect.getfullargspec() https://hg.python.org/cpython/rev/14c2d93ffcb3 -- nosy: +python-dev ___ Python tracker

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Updated patch adding What's New and NEWS entries, and addressing Martin's review comments (mostly by accepting his suggestions). I ended up leaving `inspect.getcallargs()` deprecated, and instead added a comment to issue 20438 noting how to achieve the bound

[issue27172] Undeprecate inspect.getfullargspec()

Yury Selivanov added the comment: Nick, your patch LGTM. I'd only add to the getargspec section that getfullargspec is usually a drop-in replacement (I've yet to see code where it's not the case). -- ___ Python tracker

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: Initial patch attached. Key missing pieces: - needs a What's New note - needs to undeprecate inspect.getcallargs() as well (more on that below) As my last couple of comments indicate, I'd forgotten that only getargspec() was programmatically deprecated, which

[issue27172] Undeprecate inspect.getfullargspec()

Ned Deily added the comment: Nick, that seems like the right thing to do. Thanks for following up on it. -- nosy: +larry priority: normal -> release blocker versions: +Python 3.7 ___ Python tracker

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: When we undeprecate this, we should remove and reword the deprecation warnings in the next 3.5 maintenance release as well. I'll need to decide on a way to indicate in the docs that some versions of 3.x.y will report a deprecation warning for getfullargspec()

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: This just came up in a discussion on a urllib3 patch, so I'd like to fix it for 3.6.0rc1. Ned, given that the code change here is just deleting the deprecation warning from getfullargspec() and rewording the one for getargspec(), does that seem OK for 3.6.0?

[issue27172] Undeprecate inspect.getfullargspec()

R. David Murray added the comment: Also, this is now a documentation issue, though it does require a code change for the getargspec deprecation message. -- assignee: yselivanov -> components: +Documentation -Library (Lib) keywords: -patch type: enhancement -> behavior

[issue27172] Undeprecate inspect.getfullargspec()

R. David Murray added the comment: The existing patch no longer addresses the revised decision about the API (or the new title of the issue). So, we need a new patch. -- nosy: +r.david.murray stage: commit review -> needs patch ___ Python tracker

[issue27172] Undeprecate inspect.getfullargspec()

Nick Coghlan added the comment: OK, as per the above discussion, I've changed the title of this issue to be to undeprecate inspect.getfullargspec(). That change involves two pieces: - change the documented deprecation of inspect.getfullargspec() to instead be a recommendation to avoid using