[issue27187] Relax __all__ location requirement in PEP 8

2016-06-08 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks Ian. I'm going to apply that, but rephrase it a bit. -- ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Ian Lee
Changes by Ian Lee : Added file: http://bugs.python.org/file43296/issue-27187-patch3.txt ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Ian Lee
Ian Lee added the comment: Good catch. I'm uploading a new patch that addresses ``from __future__`` imports issue explicitly. -- ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread John Mark Vandenberg
John Mark Vandenberg added the comment: The revised text says __dunder__ should appear before any imports, however __future__ imports must appear first for obvious reasons. Does this need to be mentioned in the pep? -- ___ Python tracker

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks for the patch! -- ___ Python tracker ___ ___ Python-bugs-list

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-07 Thread Roundup Robot
Roundup Robot added the comment: New changeset cf8e888b9555 by Barry Warsaw in branch 'default': Relax __all__ location. https://hg.python.org/peps/rev/cf8e888b9555 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> closed

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread John Mark Vandenberg
Changes by John Mark Vandenberg : -- nosy: +jayvdb ___ Python tracker ___ ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I added a comment on a pull request related to this that shows some of the cases that we probably don't want to allow: https://github.com/PyCQA/pycodestyle/pull/523#issuecomment-223464775 -- ___ Python tracker

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee : Added file: http://bugs.python.org/file43134/issue-27187-patch2.txt ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I might also suggest that the entire "Version bookkeeping" section could be removed in this case, as it would be covered by my newly added dunder section. -- ___ Python tracker

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Ian Lee added the comment: I think that it should be updated to specify that all dunders ('__all__', '__version__', '__author__', etc) should be placed after the module docstring and before any imports. See issue-27187-patch1.txt for a possible update. -- Added file:

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Ian Lee
Changes by Ian Lee : -- nosy: +IanLee1521 ___ Python tracker ___ ___ Python-bugs-list

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker ___

[issue27187] Relax __all__ location requirement in PEP 8

2016-06-02 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: PEP 8 says: Put any relevant __all__ specification after the imports. I don't remember why we wanted __all__ to go after imports. I think we should relax that since other dunders can go before imports. See related PYCQA issue: