[issue27659] Check for the existence of crypt()

2016-10-20 Thread Xavier de Gaye
Changes by Xavier de Gaye : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___

[issue27659] Check for the existence of crypt()

2016-10-17 Thread Martin Panter
Martin Panter added the comment: If there is an obscure platform where we don’t include the right header file for a function, changing the warning into an error would cause the build to fail. If we do make it an error, it should only be so for 3.7. --

[issue27659] Check for the existence of crypt()

2016-10-17 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Agreed. Adding -Werror=implicit-function-declaration is much simpler. Feel free to close it as rejected. -- ___ Python tracker

[issue27659] Check for the existence of crypt()

2016-10-16 Thread Xavier de Gaye
Xavier de Gaye added the comment: Android does not have crypt, but the crypt module is cross-built nevertheless after this warning has been issued: warning: implicit declaration of function 'crypt' is invalid in C99 [-Wimplicit-function-declaration] And at runtime, importing the crypt

[issue27659] Check for the existence of crypt()

2016-07-31 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Thanks, added to the patch description -- ___ Python tracker ___ ___

[issue27659] Check for the existence of crypt()

2016-07-31 Thread Xavier de Gaye
Xavier de Gaye added the comment: > A question: should I include changes to configure and pyconfig.h.in in the > patch? You just need to mention that one should run autoreconf. -- ___ Python tracker

[issue27659] Check for the existence of crypt()

2016-07-31 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Some references for crypt(): POSIX standard: http://pubs.opengroup.org/onlinepubs/9699919799/functions/crypt.html Linux man page: http://man7.org/linux/man-pages/man3/crypt.3.html FreeBSD man page: https://www.freebsd.org/cgi/man.cgi?crypt(3) Mac OS X man page:

[issue27659] Check for the existence of crypt()

2016-07-31 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Version 2: correct the name added to `missing` -- Added file: http://bugs.python.org/file43955/check-crypt.patch ___ Python tracker

[issue27659] Check for the existence of crypt()

2016-07-31 Thread Chi Hsuan Yen
New submission from Chi Hsuan Yen: On Android the crypt() function is missing, causing ugly linking errors when compiling the _crypt module. This patch handles it elegantly. A question: should I include changes to configure and pyconfig.h.in in the patch? -- components: Cross-Build