[issue27659] Prohibit implicit C function declarations

Changes by Donald Stufft : -- pull_requests: +946 ___ Python tracker ___ ___

[issue27659] Prohibit implicit C function declarations

Roundup Robot added the comment: New changeset 9a26d20d2baa27407501b13435d733dcc26f3d53 by Victor Stinner in branch 'master': Prohibit implicit C function declarations https://github.com/python/cpython/commit/9a26d20d2baa27407501b13435d733dcc26f3d53 --

[issue27659] Prohibit implicit C function declarations

STINNER Victor added the comment: Oh by the way, if someone sees a build error because of a missing function declaration, please report a new issue. -- ___ Python tracker

[issue27659] Prohibit implicit C function declarations

Chi Hsuan Yen added the comment: > If yes, can we close the issue? Yes and thanks! As a side note, on Android it prevents broken grp.cpython-37m.so, too. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue27659] Prohibit implicit C function declarations

STINNER Victor added the comment: Martin Panter: "If there is an obscure platform where we don’t include the right header file for a function, changing the warning into an error would cause the build to fail." In my experience, calling a function which was not declared is very likely to

[issue27659] Prohibit implicit C function declarations

Roundup Robot added the comment: New changeset ca2f024ce7cb by Victor Stinner in branch 'default': Prohibit implicit C function declarations https://hg.python.org/cpython/rev/ca2f024ce7cb -- nosy: +python-dev ___ Python tracker

[issue27659] Prohibit implicit C function declarations

Chi Hsuan Yen added the comment: Hello, any updates here? I hope this merged soon so that potential issues on obscure platforms can be fixed as soon as possible. -- ___ Python tracker

[issue27659] Prohibit implicit C function declarations

Martin Panter added the comment: I would say it is more important to fit in with the surrounding style than mindlessly follow PEP 7. IMO the indentation in the configure script is a mess, but if we fix it up, it should probably be done separately to adding this extra flag. --

[issue27659] Prohibit implicit C function declarations

Chi Hsuan Yen added the comment: Thanks for the comment and sorry for the mistake. Here's another updated patch. In PEP7: > Use 4-space indents and no tabs at all. Does that apply to configuration files, too? -- Added file:

[issue27659] Prohibit implicit C function declarations

Chi Hsuan Yen added the comment: > Would it be possible to not add this option for third party extensions? Good suggestion. Just use $CFLAGS_NODIST instead of $BASECFLAGS. -- Added file: http://bugs.python.org/file46036/prohibit-implicit-function-declarations.patch

[issue27659] Prohibit implicit C function declarations

STINNER Victor added the comment: Would it be possible to not add this option for third party extensions? -- ___ Python tracker ___

[issue27659] Prohibit implicit C function declarations

Chi Hsuan Yen added the comment: (Re-use the existing issue) Here's a patch that tries to add -Werror=implicit-function-declaration to $BASECFLAGS. This is useful for cross-compiling. When a function is missing, the error jumps out during the build time rather than runtime. Tested