[issue27820] Possible bug in smtplib when initial_response_ok=False

Senthil Kumaran added the comment: Please open a new issue. It has better chances of being fixed quickly. On Mon, Apr 26, 2021 at 10:02 PM junpengruan wrote: > > junpengruan <632077...@qq.com> added the comment: > > Hi > I think there is another bug when initial_response_ok=False. When

[issue27820] Possible bug in smtplib when initial_response_ok=False

junpengruan <632077...@qq.com> added the comment: Hi I think there is another bug when initial_response_ok=False. When using AUTH PLAIN, the server will response like: -- C: AUTH PLAIN S: 334 ok. go on -- and it's not base64 encoding, while in the auth() it will

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Senthil Kumaran added the comment: New changeset 8cadc2c9cacfa1710cb5ca28a70f7782cacf09aa by Senthil Kumaran in branch '3.8': [3.8] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) (#24833) https://github.com/python/cpython/commit/8cadc2c9cacfa1710cb5ca28a70f7782cacf09aa

[issue27820] Possible bug in smtplib when initial_response_ok=False

Senthil Kumaran added the comment: New changeset 32717b982d3347e30ae53eb434e2a32e0d03d51e by Miss Islington (bot) in branch '3.9': bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) (#24832) https://github.com/python/cpython/commit/32717b982d3347e30ae53eb434e2a32e0d03d51e

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Senthil Kumaran : -- pull_requests: +23599 pull_request: https://github.com/python/cpython/pull/24833 ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +23598 pull_request: https://github.com/python/cpython/pull/24832 ___ Python tracker

[issue27820] Possible bug in smtplib when initial_response_ok=False

Senthil Kumaran added the comment: New changeset 7591d9455eb37525c832da3d65e1a7b3e6dbf613 by Pandu E POLUAN in branch 'master': bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118) https://github.com/python/cpython/commit/7591d9455eb37525c832da3d65e1a7b3e6dbf613 --

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: Hi Senthil, You're right, it does need a guard. According to my knowledge there is no AUTH mechanism that will send more than 3 challenges; they should fail afterwards with 535 or similar. Servers that don't do that should be considered buggy/broken. So

[issue27820] Possible bug in smtplib when initial_response_ok=False

Senthil Kumaran added the comment: Hello Pandu, Thank you for this patch and the explanation. Does client blocking on repeated challenge from the server (using of while loop) look okay here? The conversation here indicates to me that it is fine. Is there any recommendation or

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: PR available on GitHub and it's already more than one month since the PR was submitted, so I'm pinging this issue. -- ___ Python tracker

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Pandu E POLUAN : -- components: +Tests ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Pandu E POLUAN : -- keywords: +patch pull_requests: +22948 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24118 ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: Okay, I finally figured out what's wrong. This piece of code in `test_smtplib.py`: if self.smtp_state == self.AUTH: line = self._emptystring.join(self.received_lines) print('Data:', repr(line), file=smtpd.DEBUGSTREAM)

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: I tried adding the code below to test_smtplib.py: def testAUTH_LOGIN_initial_response_notok(self): self.serv.add_feature("AUTH LOGIN") smtp = smtplib.SMTP(HOST, self.port, local_hostname='localhost',

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: I tried creating a PR, but for the life of me I couldn't wrap my head around how testAUTH_LOGIN is being performed (it's in Lib/test/test_smtplib.py) All I know is, the test doesn't AT ALL test for situations where initial_response_ok=False. ALL tests are

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Rahul Kumaresan : -- nosy: +rahul-kumi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: This issue is still a bug for Python 3.6 and Python 3.8 I haven't checked on Python 3.7 and Python 3.9 -- versions: +Python 3.6, Python 3.8 ___ Python tracker

[issue27820] Possible bug in smtplib when initial_response_ok=False

Pandu E POLUAN added the comment: Hi, I'm one of the maintainers of aio-libs/aiosmtpd. This issue also bit me when trying to write unit tests for aio-libs/aiosmtpd AUTH implementation But I partially disagree with Dario D'Amico's changes, specifically the suggested change in the

[issue27820] Possible bug in smtplib when initial_response_ok=False

iMath added the comment: I encountered the same issue , Dario D'Amico's changing works ! please fix the problem ! -- nosy: +redstone-cold ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Change by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27820] Possible bug in smtplib when initial_response_ok=False

Mario Colombo added the comment: Yes, this (or something similar) totally bit me, when for another unrelated reason 'AUTH PLAIN' authentication failed: https://gist.github.com/macolo/bf2811c14d985d013dda0741bfd339e0 Python then tries auth_login, but doesn't send 'AUTH LOGIN' to the mail

[issue27820] Possible bug in smtplib when initial_response_ok=False

Changes by R. David Murray : -- components: +email nosy: +barry, r.david.murray ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Dario D'Amico added the comment: I have reasons to believe that smtlib.py does not support AUTH LOGIN well. My guts feeling are that the auth_login method should be changed into: def auth_login(self, challenge=None): print("auth_login", challenge) """ Authobject to use with

[issue27820] Possible bug in smtplib when initial_response_ok=False

New submission from Dario D'Amico: oo -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27820] Possible bug in smtplib when initial_response_ok=False

Changes by Dario D'Amico : Removed file: http://bugs.python.org/file44177/SmtplibBugReport.txt ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Changes by Dario D'Amico : Added file: http://bugs.python.org/file44177/SmtplibBugReport.txt ___ Python tracker ___

[issue27820] Possible bug in smtplib when initial_response_ok=False

Changes by Dario D'Amico : -- components: Library (Lib) nosy: Dario D'Amico priority: normal severity: normal status: open title: Possible bug in smtplib when initial_response_ok=False type: crash versions: Python 3.5 ___