Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +gvanrossum
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
___
Python-bugs-list mailing
Antoine Pitrou added the comment:
The reason I didn't put __qualname__ on code objects is that code objects don't
have a __module__ either. That information, up to now, belongs on the module.
Conceptually, a code object could very well be used by multiple functions
living in different
Antoine Pitrou added the comment:
Correcting myself:
That information, up to now, belongs on the module.
on the function, of course.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
Ben Longbons added the comment:
I made a minimal gist of my motivating code:
https://gist.github.com/o11c/ce0c2ff74b87ea71ad46
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Ben Longbons added the comment:
Code objects currently have no mutable fields.
So what are you planning to do about things like:
Foo = namedtuple('Foo', 'x y')
def frob(self):
return self.x + self.y
# probably actually done via a @member(Foo) decorator
# so adding more code here is not a
Nick Coghlan added the comment:
Moving this back to patch review while we consider the alternative approach of
moving qualname storage into code objects, rather than continuing to transport
qualnames separately.
--
stage: commit review - patch review
Nick Coghlan added the comment:
Moving target version to 3.6 (since we're discussing adding a new public C API).
This is an interesting problem, as seeing an expanding API like this
(PyEval_EvalCode - PyEval_EvalCodeEx - PyEval_EvalCodeEx2) suggests to me
that we actually have a missing
Robert Collins added the comment:
Forgot docs - I'll do before committing, but not worried about review of them
so much.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Robert Collins added the comment:
Ok, so this is an API and ABI change. I'm going to do a variant without that
downside.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Robert Collins added the comment:
And herewith.
--
Added file: http://bugs.python.org/file40250/issue-2786-1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Changes by Robert Collins robe...@robertcollins.net:
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Daniil Bondarev added the comment:
Addrressed feedback: splitted long line in multiple in tests.
--
Added file: http://bugs.python.org/file38904/full_names.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
Daniil Bondarev added the comment:
issue17911 was submitted. I pulled latest updates and rechecked that ./python
-m test -uall passing with the same patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
Matthias Urlichs added the comment:
Please do.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
___
Python-bugs-list mailing list
Daniil Bondarev added the comment:
As long as you think It fits into your issue, I'm ok with adding this patch to
it (: it's different files, so no conflicts. Should I just add this patch to
your ticket?
--
___
Python tracker rep...@bugs.python.org
Robert Collins added the comment:
I wonder if you could add this to the new code in
http://bugs.python.org/issue17911 which I'm hoping to commit this week.
--
nosy: +rbcollins
___
Python tracker rep...@bugs.python.org
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
___
Python-bugs-list
Daniil Bondarev added the comment:
Made a straightforward patch for this. Probably not that pretty, so suggestions
are welcome.
Note that some function names will become pretty long in exceptions:
class A:
... def __init__(self):
... def f():
... pass
...
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Illia Polosukhin added the comment:
The issue is not that easy to address - because PyFunctionObject is not
available from PyEval_EvalCodeEx.
Another note, is that the issue of reporting only function name without class
name is observed in many places, not just for example above.
Still, will
Illia Polosukhin added the comment:
Talked with David Murray (r.david.murray) at @pycon2013 sprints - will try to
address this.
--
nosy: +ilblackdragon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
Ezio Melotti added the comment:
Perhaps __qualname__ could be used in the traceback.
--
keywords: +easy
nosy: +ezio.melotti, pitrou
stage: - needs patch
versions: +Python 3.4 -Python 3.2
___
Python tracker rep...@bugs.python.org
Changes by Terry J. Reedy tjre...@udel.edu:
--
versions: +Python 3.2 -Python 2.6, Python 3.0
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2786
___
Alexander Belopolsky [EMAIL PROTECTED] added the comment:
This is similar to issue2516.
--
nosy: +belopolsky
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2786
__
___
New submission from Matthias Urlichs [EMAIL PROTECTED]:
Consider this simple error:
class foo(object):
... def __init__(self,bar):
...pass
...
foo()
Traceback (most recent call last):
File stdin, line 1, in module
TypeError: __init__() takes exactly 2 positional arguments (1 given)
25 matches
Mail list logo
