[issue28187] Check return value of _PyBytes_Resize

Berker Peksag added the comment: Thanks for the review, Serhiy! Good point, closing this as 'not a bug'. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue28187] Check return value of _PyBytes_Resize

Serhiy Storchaka added the comment: In all cases _PyBytes_Resize is followed by return. Original code is correct. In either way NULL is returned if _PyBytes_Resize fails. -- ___ Python tracker

[issue28187] Check return value of _PyBytes_Resize

Changes by Berker Peksag : Added file: http://bugs.python.org/file44711/pybytes_resize_regenerated.diff ___ Python tracker ___ ___ Python-bugs

[issue28187] Check return value of _PyBytes_Resize

Serhiy Storchaka added the comment: Could you please regenerate the patch for Rietveld Berker? _PyBytes_Resize(&res, r) always sets res to NULL if fails. Thus the following code is correct. No need to check the return value. if (n > r) _PyBytes_Resize(&res, r); return res; ---

[issue28187] Check return value of _PyBytes_Resize

Christian Heimes added the comment: Yes, it can fail for multiple reasons: wrong type, ref count != 1, realloc() fails to allocate a smaller area. -- nosy: +christian.heimes ___ Python tracker

[issue28187] Check return value of _PyBytes_Resize

Martin Panter added the comment: Can the resize fail if the buffer is only being strunk? I haven’t looked closely, but maybe that’s why some of the cases don’t check for failure. -- nosy: +martin.panter ___ Python tracker

[issue28187] Check return value of _PyBytes_Resize

New submission from Berker Peksag: There are a couple of instances that don't check return value of _PyBytes_Resize in Modules/. I noticed this while working on issue 25270. Patch attached. -- components: Extension Modules files: pybytes_resize.diff keywords: patch messages: 276778 nos