[issue28216] micro optimization for import_all_from

2016-09-20 Thread Xiang Zhang
Xiang Zhang added the comment: As pointed out by Serhiy, PyObject_GetAttr may change __all__ so my proposal is not going to work. Close this and sorry for noise. :-( -- resolution: -> rejected stage: patch review -> resolved status: open -> closed

[issue28216] micro optimization for import_all_from

2016-09-20 Thread Xiang Zhang
New submission from Xiang Zhang: Since PyMapping_Keys always return a list or tuple and most __all__s are list (all in stdlib), I think we can avoid calling PySequence_GetItem for every key and use PySequence_Fast* APIs instead. This doesn't help much since other operations involved are