[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +1040 ___ Python tracker ___ ___

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset dcb39d3ba67a by Serhiy Storchaka in branch 'default': Issue #28289: ImportError.__init__ now resets not specified attributes. https://hg.python.org/cpython/rev/dcb39d3ba67a -- nosy: +python-dev ___

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Brett. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ Python tracker

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Brett Cannon
Brett Cannon added the comment: And I say don't worry about backporting. -- ___ Python tracker ___ ___

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Brett Cannon
Brett Cannon added the comment: Patch LGTM. -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a simple patch. But I'm not sure that this is a bug. -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file44848/importerror-reset-attributes.patch ___ Python tracker

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Brett Cannon
Brett Cannon added the comment: I think it's a bug, but a low priority one. -- priority: normal -> low ___ Python tracker ___

[issue28289] ImportError.__init__ doesn't reset not specified exception attributes

2016-09-27 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: ImportError.__init__ sets only specified attributes ("msg", "name" or "path"), and left not explicitly specified attributes unchanged. >>> err = ImportError('test', name='name') >>> err.args, err.msg, err.name, err.path (('test',), 'test', 'name', None)