[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +1004 ___ Python tracker ___ ___

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-10-25 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-10-25 Thread Roundup Robot
Roundup Robot added the comment: New changeset ca1b91829edf by Serhiy Storchaka in branch '3.5': Issue #28314: Added tests for xml.etree.ElementTree.Element.getiterator(). https://hg.python.org/cpython/rev/ca1b91829edf New changeset c14a2d2a3b19 by Serhiy Storchaka in branch '3.6': Issue

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-10-10 Thread Ned Deily
Changes by Ned Deily : -- stage: needs patch -> patch review ___ Python tracker ___ ___

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a test. -- Added file: http://bugs.python.org/file44882/test_getiterator.patch ___ Python tracker ___

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread STINNER Victor
STINNER Victor added the comment: I pushed the first obvious fix to unblock the 3.6 beta 2 release scheduled for next monday. -- priority: release blocker -> ___ Python tracker

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e29dca5dc4c by Victor Stinner in branch '3.6': Fix xml.etree.ElementTree.Element.getiterator() https://hg.python.org/cpython/rev/1e29dca5dc4c -- nosy: +python-dev ___ Python tracker

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread STINNER Victor
Changes by STINNER Victor : -- priority: critical -> release blocker ___ Python tracker ___

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread STINNER Victor
STINNER Victor added the comment: Oh... Modules/_elementtree.c uses a function defined in Modules/clinic/_elementtree.c. It hardcodes flags, whereas flags changed. Maybe the alias should be created differently to avoid such issue in the future? Moreover, obviously, we lack unit tests on this

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread STINNER Victor
STINNER Victor added the comment: The bug seems related to the new FASTCALL calling convention introduced in Python 3.6b1. For an unknown reason, the METH_FASTCALL defined in Modules/clinic/_elementtree.c on _elementtree_Element_iter() seems to be ignored or lost somewhere? -- nosy:

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread Ned Deily
Ned Deily added the comment: Even better: Python 3.6.0b1 (v3.6.0b1:5b0ca4ed5e2f, Sep 12 2016, 09:24:46) [GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> from xml.etree.ElementTree import Element >>> el =

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

2016-09-29 Thread Dmitry Shachnev
New submission from Dmitry Shachnev: The documentation says that getiterator() still accepts a tag argument, but it does not: >>> from xml.etree.ElementTree import Element >>> el = Element('foo') >>> el.getiterator('bar') Traceback (most recent call last): File "", line 1, in SystemError: