[issue28409] test.regrtest does not support multiple -x flags

Changes by Donald Stufft : -- pull_requests: +910 ___ Python tracker ___ ___

[issue28409] test.regrtest does not support multiple -x flags

STINNER Victor added the comment: Serhiy Storchaka added the comment: > What is the difference between using parse_known_args() and nargs=argparse.REMAINDER? Using REMAINDER, args become ["b", "-c", "d"] for -a b -c d. I would be happy to not use parse_known_args(), but I didn't find how.

[issue28409] test.regrtest does not support multiple -x flags

Serhiy Storchaka added the comment: What is the difference between using parse_known_args() and nargs=argparse.REMAINDER? -- ___ Python tracker ___

[issue28409] test.regrtest does not support multiple -x flags

STINNER Victor added the comment: Thanks for the bug report Charalampos! It's now fixed. -- > Until python3.6.0a04 it was possible to pass multiple times the -x option at > regrtest. To be clear: the regrtest parser of command line argument was broken since Python 2.7 at least. "./python

[issue28409] test.regrtest does not support multiple -x flags

Roundup Robot added the comment: New changeset af06d9616c29 by Victor Stinner in branch '3.5': Issue #28409: regrtest: fix the parser of command line arguments. https://hg.python.org/cpython/rev/af06d9616c29 New changeset 26249f82c15d by Victor Stinner in branch '3.6': Merge 3.6: Issue #28409:

[issue28409] test.regrtest does not support multiple -x flags

STINNER Victor added the comment: Attached patch should fix the issue. I didn't know that argparse was so strict: "arg1 -v arg2" is not supported by default, see the issue #14191, whereas it works well with optparse. The patch uses parse_known_args() as a workaround, and then manually checks

[issue28409] test.regrtest does not support multiple -x flags

STINNER Victor added the comment: Xiang: "This regression is introduced in 4df2d43e995d." Sorry, my commit message is very short. I made this change because I was very annoying of getting "unknown test -m" and "unknown test test_access" when using the -m option to filter tests: ./python

[issue28409] test.regrtest does not support multiple -x flags

Serhiy Storchaka added the comment: No, this is not a regression in argparse itself, nor in regrtest (as Xiang pointed, original example is incorrect use). But I'm not sure about the support of options after positional arguments. This is dangerous feature. I'm going to investigate this

[issue28409] test.regrtest does not support multiple -x flags

R. David Murray added the comment: OK, so this isn't a regression in argparse itself? I thought you meant it was, which is why I set it to release blocker. -- ___ Python tracker

[issue28409] test.regrtest does not support multiple -x flags

Serhiy Storchaka added the comment: Indeed, previously -x in the middle of test names worked only by accident, because it was interpreted as the name of excluded test. Now it stops positional arguments. Current behavior is explainable, but surprising. This part of argparse is not clear and

[issue28409] test.regrtest does not support multiple -x flags

Xiang Zhang added the comment: > ./python -m test.regrtest test_unary -v test_binop > ./python -m test.regrtest test_unary -u all test_binop These also fail in 3.6.0a4. You can only specify options after args now. test_binop is not valid option. Isn't this the expected behaviour?

[issue28409] test.regrtest does not support multiple -x flags

Serhiy Storchaka added the comment: This issue is not specific to -x, but affects all options. Following lines work: ./python -m test.regrtest -v test_unary test_binop ./python -m test.regrtest -u all test_unary test_binop ./python -m test.regrtest test_unary test_binop -v

[issue28409] test.regrtest does not support multiple -x flags

Xiang Zhang added the comment: So should we still consider this a regression? Actually -x is used as a hint flag and should not be used as -x arg pair. The right usage could still work now. -- ___ Python tracker

[issue28409] test.regrtest does not support multiple -x flags

Xiang Zhang added the comment: This regression is introduced in 4df2d43e995d. And actually to skip multiple tests, you should use python3 -m test.regrtest -x test_venv test_gdb. Although Charalampos's example could work, it actually treats -x as a test. -- nosy: +xiang.zhang

[issue28409] test.regrtest does not support multiple -x flags

R. David Murray added the comment: That sounds like a regression in argparse that we'd better track down. -- nosy: +larry, ned.deily, r.david.murray priority: normal -> release blocker ___ Python tracker

[issue28409] test.regrtest does not support multiple -x flags

Serhiy Storchaka added the comment: Seems this is related to some changes in argparse. -- nosy: +bethard, serhiy.storchaka versions: +Python 3.5 ___ Python tracker

[issue28409] test.regrtest does not support multiple -x flags

Changes by Serhiy Storchaka : -- nosy: +haypo stage: -> needs patch type: -> behavior versions: +Python 3.7 ___ Python tracker

[issue28409] test.regrtest does not support multiple -x flags

New submission from Charalampos Stratakis: Until python3.6.0a04 it was possible to pass multiple times the -x option at regrtest. However since the 3.6.0b1 when trying the same thing I get an error. Test names are random. python3 -m test.regrtest -x test_venv -x test_gdb usage: python -m