[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Gregory P. Smith added the comment: I'm going to close this as 3.7 and 3.8 are good now, but if someone wants to see the same thing done in 2.7 it should be possible for them make a PR. This is primarily just a configure.ac change. -- resolution: -> fixed stage: commit review ->

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Gregory P. Smith added the comment: New changeset a144feeb7ec501aaf30072d50e70d54b200e5ef0 by Gregory P. Smith (Miss Islington (bot)) in branch '3.7': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) (GH-11376)

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Gregory P. Smith added the comment: As this is internal only rather than a feature, i'll bring this into 3.7 as well. -- versions: +Python 3.7 ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by miss-islington : -- pull_requests: +10718 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Gregory P. Smith added the comment: New changeset 387512c7ecde6446f2e29408af2e16b9fc043807 by Gregory P. Smith in branch 'master': bpo-28503: Use crypt_r() when available instead of crypt() (GH-11373) https://github.com/python/cpython/commit/387512c7ecde6446f2e29408af2e16b9fc043807

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by miss-islington : -- pull_requests: +10718, 10719 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by miss-islington : -- pull_requests: +10718, 10719, 10720 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- pull_requests: +10712, 10713, 10714 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- pull_requests: +10712, 10713 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- pull_requests: +10712 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Change by Roundup Robot : -- pull_requests: +4604 stage: -> patch review ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Ed Schouten added the comment: Ah, you folks switched to Git + Github in the mean time. Nice! I've just sent this pull request: https://github.com/python/cpython/pull/4691 -- ___ Python tracker

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Benjamin Peterson added the comment: This sgtm. Can you send a PR? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Ed Schouten added the comment: Having looked at various implementations of crypt() and crypt_r(), I can't think of a reason why there would be any significant difference in performance. On systems like FreeBSD, crypt() is just a simple wrapper around crypt_r():

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Antoine Pitrou added the comment: I'm not sure performance matters. Modern crypt() algorithms should actually be slow enough (using a large number of rounds) to make brute-force attacks impractical... -- nosy: +pitrou versions: +Python 3.7 -Python 3.6

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Serhiy Storchaka added the comment: What is the performance of crypt_r() in comparison with crypt()? -- nosy: +serhiy.storchaka ___ Python tracker

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

Changes by Xavier de Gaye : -- nosy: +xdegaye ___ Python tracker ___ ___ Python-bugs-list

[issue28503] [Patch] '_crypt' module: fix implicit declaration of crypt(), use crypt_r() where available

New submission from Ed Schouten: The '_crypt' module provides a binding to the C crypt(3) function. It is used by the crypt.crypt() function. Looking at the C code, there are a couple of things we can improve: - Because crypt() only depends on primitive C types, we currently get away with