[issue28504] Cleanup unicode_decode_call_errorhandler_wchar/writer

2016-10-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. Thank you Xiang. I have extended your approach to all sources and have written other two patches: issues28510 and issue28511. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue28504] Cleanup unicode_decode_call_errorhandler_wchar/writer

2016-10-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 204a43c452cc by Serhiy Storchaka in branch 'default': Issue #28504: Cleanup unicode_decode_call_errorhandler_wchar/writer. https://hg.python.org/cpython/rev/204a43c452cc -- nosy: +python-dev ___ Python

[issue28504] Cleanup unicode_decode_call_errorhandler_wchar/writer

2016-10-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue28504] Cleanup unicode_decode_call_errorhandler_wchar/writer

2016-10-22 Thread Xiang Zhang
New submission from Xiang Zhang: The patch makes several cleanups to unicode_decode_call_errorhandler_wchar/writer: 1. Use U instead O! for argument parser, it ought to be more efficient and write less code. 2. In theory, if inputobj is not bytes, there needs to be a goto onError, or it