[issue28595] shlex.shlex should not augment wordchars

Change by Vinay Sajip : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.8 -Python 3.6, Python 3.7 ___ Python tracker ___

[issue28595] shlex.shlex should not augment wordchars

Vinay Sajip added the comment: New changeset 56624a99a916fd27152d5b23364303acc0d707de by Vinay Sajip (Evan) in branch 'master': bpo-28595: Allow shlex whitespace_split with punctuation_chars (GH-2071) https://github.com/python/cpython/commit/56624a99a916fd27152d5b23364303acc0d707de

[issue28595] shlex.shlex should not augment wordchars

Evan Andrews added the comment: Thanks, Vinay. I understand you're busy, and I'm in no particular rush to have this looked at, so feel free to come back to it when you have more time. I've submitted the changes as a PR. I also have an additional concern - even with this change, there is no

[issue28595] shlex.shlex should not augment wordchars

Changes by Evan Andrews : -- pull_requests: +2134 ___ Python tracker ___ ___

[issue28595] shlex.shlex should not augment wordchars

Vinay Sajip added the comment: > Do I need to create a pull request for this? Yes, creating a PR is part of the current workflow since we moved to GitHub. Though that's not the reason why it's not been progressed - on my part, at least, it's due to not having had time to think through the

[issue28595] shlex.shlex should not augment wordchars

Evan Andrews added the comment: Do I need to create a pull request for this? -- ___ Python tracker ___ ___

[issue28595] shlex.shlex should not augment wordchars

Evan Andrews added the comment: Unfortunately shlex.shlex's defaults are probably going to remain that way for a long time in order to avoid breaking backwards compatibility. Presumably shlex.split was added so you didn't have to remember to set posix and whitespace_split yourself. The

[issue28595] shlex.shlex should not augment wordchars

Gustavo Goretkin added the comment: Sorry, I typo'd that last example pretty badly. Should be >>> list(shlex.shlex(b"mkdir Bad\xffButLegalPath".decode("utf-8", >>> "surrogateescape"))) ['mkdir', 'Bad', '\udcff', 'ButLegalPath'] -- ___ Python

[issue28595] shlex.shlex should not augment wordchars

Gustavo Goretkin added the comment: >Instead of trying to enumerate all possible wordchars, I think a more robust >solution is to use whitespace_split to include *all* characters not otherwise >considered special. I agree with that approach. Also note that dash/hyphen gets incorrectly

[issue28595] shlex.shlex should not augment wordchars

Evan Andrews added the comment: Attaching an updated patch now that the two linked issues are resolved. -- Added file: http://bugs.python.org/file46335/shlex2.diff ___ Python tracker

[issue28595] shlex.shlex should not augment wordchars

Evan added the comment: I've attached a more complete patch. This takes the conservative approach of retaining all functionality of 3.6 and treating this as a new feature for 3.7. I don't think this is suitable for 3.6.1 given this new behavior contradicts what is currently written in the

[issue28595] shlex.shlex should not augment wordchars

Evan added the comment: I've created issue28784 to capture the documentation fixes. When I have more spare time, I'll work on a more complete patch. -- ___ Python tracker

[issue28595] shlex.shlex should not augment wordchars

R. David Murray added the comment: Per our conversation on IRC: since this is not a regression, it is unlikely to be addressed at this stage of the 3.6 release cycle. I'm adding the release manager as nosy just in case, but I don't expect him to want this to be addressed now. IMO if the

[issue28595] shlex.shlex should not augment wordchars

Evan added the comment: I have some additional concerns with the changes introduced in http://bugs.python.org/issue1521950: 1. The fact that posix defaults to False in shlex.shlex (but not in shlex.split) is a huge beginner trap. If users are expecting to use this for "compatibility with the

[issue28595] shlex.shlex should not augment wordchars

Changes by Evan : -- title: shlex.split should not augment wordchars -> shlex.shlex should not augment wordchars ___ Python tracker