[issue28655] Tests altered the execution environment in isolated mode

STINNER Victor added the comment: New changeset 4687bc993a275eaeb27a8b2068b128ce1f464818 by Victor Stinner (Maite Giménez) in branch '3.6': bpo-28655: Fix test bdb for isolate mode (GH-10220) https://github.com/python/cpython/commit/4687bc993a275eaeb27a8b2068b128ce1f464818 --

[issue28655] Tests altered the execution environment in isolated mode

Change by Roundup Robot : -- pull_requests: +9536 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28655] Tests altered the execution environment in isolated mode

Karthikeyan Singaravelan added the comment: I guess this can be safely closed as fixed since 3.6 changes were merged and I verified the PR changes locally at msg326477. The issue regarding using -I along with -j0 is tracked at issue34812 . Thanks Serhiy and Victor for the fixes :)

[issue28655] Tests altered the execution environment in isolated mode

STINNER Victor added the comment: New changeset 43500a5907eb9ae2e470dcbffe73012cd456f5a1 by Victor Stinner in branch '3.6': bpo-28655: Fix test_import.test_missing_source_legacy() (GH-9589) https://github.com/python/cpython/commit/43500a5907eb9ae2e470dcbffe73012cd456f5a1 --

[issue28655] Tests altered the execution environment in isolated mode

STINNER Victor added the comment: > I can confirm this on 3.6. Interestingly `--fail-env-changed` flag didn't > catch this but running in verbose mode failed. Oh... When using -j0, regrtest doesn't spawn worker processes using -I: the flag is simply omitted... As a side effect, forget() in

[issue28655] Tests altered the execution environment in isolated mode

Karthikeyan Singaravelan added the comment: Verified the fix in the PR and there are no warnings ➜ cpython git:(pr_9589) ./python.exe Python 3.6.6+ (heads/pr_9589:844abda318, Sep 26 2018, 20:59:26) [GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin Type "help", "copyright",

[issue28655] Tests altered the execution environment in isolated mode

Karthikeyan Singaravelan added the comment: Thanks Serhiy. Thanks Victor for the fix. I can confirm this on 3.6. Interestingly `--fail-env-changed` flag didn't catch this but running in verbose mode failed. `--fail-env-changed` passes ➜ cpython git:(3707bcf02b) ./python.exe -I -S -m

[issue28655] Tests altered the execution environment in isolated mode

STINNER Victor added the comment: > test_import still fails on 3.6. Oh, I only tested master. I wrote PR 9589 to fix test_import on 3.6. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue28655] Tests altered the execution environment in isolated mode

Change by STINNER Victor : -- pull_requests: +8986 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28655] Tests altered the execution environment in isolated mode

Serhiy Storchaka added the comment: test_import still fails on 3.6. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28655] Tests altered the execution environment in isolated mode

STINNER Victor added the comment: I confirm that "./python -I -S -m test.regrtest -j0 --fail-env-changed test_asyncio test_ctypes test_email test_idle test_import test_importlib test_json test_lib2to3" now pass on master. I close the issue. Thanks Karthikeyan ;-) -- resolution: ->

[issue28655] Tests altered the execution environment in isolated mode

Karthikeyan Singaravelan added the comment: The dependency issue31837 dealing with test_lib2to3 failure was resolved by Victor in issue30117 and hence I marked it as a duplicate. The other issue regarding test_import is not reproducible on master as of

[issue28655] Tests altered the execution environment in isolated mode

Change by Serhiy Storchaka : -- dependencies: +ParseError in test_all_project_files() ___ Python tracker ___

[issue28655] Tests altered the execution environment in isolated mode

Serhiy Storchaka added the comment: Most warnings are fixed in issue19398. The only warnings are left in test_import and test_lib2to3. $ ./python -I -S -m test.regrtest -vv test_import test_lib2to3 >/dev/null Warning -- files was modified by test_import Before: [] After:

[issue28655] Tests altered the execution environment in isolated mode

New submission from Serhiy Storchaka: Following tests altered the execution environment in isolated mode: test_asyncio test_ctypes test_email test_idle test_import test_importlib test_json test_lib2to3 $ ./python -I -S -m test.regrtest -vv test_asyncio test_ctypes test_email test_idle