[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Batuhan added the comment: PR 14079 has been merged, is there anything left as unresolved about this issue? -- nosy: +BTaskaya ___ Python tracker ___ _

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

miss-islington added the comment: New changeset e784f9f1c3fdd2102aae3fc0fe226408ff3a6029 by Miss Islington (bot) in branch '3.8': bpo-28805: document METH_FASTCALL (GH-14079) https://github.com/python/cpython/commit/e784f9f1c3fdd2102aae3fc0fe226408ff3a6029 -- __

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

miss-islington added the comment: New changeset b101fa7783615051a89500e488708b955eac94c5 by Miss Islington (bot) in branch '3.7': bpo-28805: document METH_FASTCALL (GH-14079) https://github.com/python/cpython/commit/b101fa7783615051a89500e488708b955eac94c5 -- nosy: +miss-islington

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Change by miss-islington : -- pull_requests: +13979 pull_request: https://github.com/python/cpython/pull/14137 ___ Python tracker ___ __

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Change by miss-islington : -- pull_requests: +13978 pull_request: https://github.com/python/cpython/pull/14136 ___ Python tracker ___ __

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Inada Naoki added the comment: New changeset 5600b5e1b24a3491e83f1b3038a7ea047a34c0bf by Inada Naoki (Jeroen Demeyer) in branch 'master': bpo-28805: document METH_FASTCALL (GH-14079) https://github.com/python/cpython/commit/5600b5e1b24a3491e83f1b3038a7ea047a34c0bf -- nosy: +inada.na

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Change by Jeroen Demeyer : -- keywords: +patch pull_requests: +13938 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14079 ___ Python tracker __

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Jeroen Demeyer added the comment: Victor, of the four functions you mentioned: - _PyObject_FastCallDict: documented by PEP 590 - _PyObject_FastCallKeywords: renamed _PyObject_Vectorcall and documented by PEP 590 - _PyObject_FastCall: not sure if it's useful enough (just use _PyObject_Vecto

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

STINNER Victor added the comment: I suggest to document the following 4 functions/macros: PyAPI_FUNC(PyObject *) _PyObject_FastCallDict( PyObject *callable, PyObject **args, Py_ssize_t nargs, PyObject *kwargs); PyAPI_FUNC(PyObject *) _PyObject_FastCallKeywords( PyObject *ca

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

STINNER Victor added the comment: > It would also be nice if Cython could use it automatically. Cython is using FASTCALL since Python 3.6. -- ___ Python tracker ___ __

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

STINNER Victor added the comment: > Can we please document these for Python 3.7 at least? I chose to not document FASTCALL on purpose in Python 3.6, I wanted to keep everything private, until we get enough feedback and stabilize the API. Recently, the FASTCALL API changed: METH_FASTCALL doesn

[issue28805] Add documentation for METH_FASTCALL

Barry A. Warsaw added the comment: This and the _PyObject_FastCall* APIs really do need to be documented, especially if they're going to be used in the interpreter itself. The leading underscore signifies that it's not part of the public API (well, METH_FASTCALL doesn't have a leading unders

[issue28805] Add documentation for METH_FASTCALL and _PyObject_FastCall*()

Change by Barry A. Warsaw : -- title: Add documentation for METH_FASTCALL -> Add documentation for METH_FASTCALL and _PyObject_FastCall*() ___ Python tracker ___ __

[issue28805] Add documentation for METH_FASTCALL

Serhiy Storchaka added the comment: > Ah? Can you please elaborate your secret plan? :-) I already said about this. Move the part of parsing keyword argument outside of the function. The caller should unpack keyword arguments and pass just a raw array of PyObject*. Missed arguments are set to

[issue28805] Add documentation for METH_FASTCALL

Stefan Krah added the comment: There are a couple of problems with using Argument Clinic for third party projects. First, it makes no stability promises: "Currently Argument Clinic is considered internal-only for CPython. ..." Then, for large projects that already use some generated code (lik

[issue28805] Add documentation for METH_FASTCALL

STINNER Victor added the comment: Is it possible to use Argument Clinic for third party extensions? If yes, I suggest to use it. It would also be nice if Cython could use it automatically. So we can suggest to use Cython. I don't know well Cython, maybe your idea is very dumb :-) Serhiy Storcha

[issue28805] Add documentation for METH_FASTCALL

Serhiy Storchaka added the comment: I suggest to keep it internal. It's meaning may be changed in future. I have some ideas about making it more convenient and faster (but I'm not sure that they would work). -- ___ Python tracker

[issue28805] Add documentation for METH_FASTCALL

New submission from Stefan Krah: It looks like METH_FASTCALL gives nice speedups (#28754). Is this an internal interface or can it be documented like METH_KEYWORDS etc.? -- assignee: docs@python components: Documentation messages: 281766 nosy: docs@python, haypo, serhiy.storchaka, skrah