[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +935 ___ Python tracker ___ ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Ned and Victor. -- priority: release blocker -> normal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset b431d39da67f by Serhiy Storchaka in branch '3.5': Issue #28808: PyUnicode_CompareWithASCIIString() now never raises exceptions. https://hg.python.org/cpython/rev/b431d39da67f New changeset 5bdc8e1a50c8 by Serhiy Storchaka in branch '3.6': Issue

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-05 Thread STINNER Victor
STINNER Victor added the comment: PyUnicode_CompareWithASCIIString-no-errors-2.patch LGTM. Go ahead Serhiy. -- ___ Python tracker ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-05 Thread Ned Deily
Ned Deily added the comment: This is currently blocking 360rc1. Victor, Serhiy, we either need to get this in now or wait until 3.6.1. I am leaning towards pushing the latest patch for 3.6 without having a decision about 3.5 yet. -- ___ Python

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-12-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch addresses some Victor's comments. But I disagree that this bugfix needs a versionchanged directive. -- Added file: http://bugs.python.org/file45734/PyUnicode_CompareWithASCIIString-no-errors-2.patch

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-29 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Usually we don't add "versionchanged" for every fixed bug. -- ___ Python tracker ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-29 Thread STINNER Victor
STINNER Victor added the comment: >> The function was already documented in Python 3.5, so please add a ".. >> versionchanged:: 3.6" to document the API chnange. > No, this behavior is not documented in any released Python version. The note > about the failure was added in issue28701. Ah

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-28 Thread STINNER Victor
STINNER Victor added the comment: I reviewed PyUnicode_CompareWithASCIIString-no-errors.patch. -- ___ Python tracker ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-28 Thread Ned Deily
Ned Deily added the comment: I'd like @haypo to review and approve this change as well since he was involved in the predecessor (Issue28701). Victor? -- ___ Python tracker

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-28 Thread Ned Deily
Changes by Ned Deily : -- nosy: +larry priority: normal -> release blocker ___ Python tracker ___

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Xiang. Ned, I ask your permission for committing this patch in 3.6. This is not critical neither new bug, it was introduced in 3.3 and is rarely reproducible. But 3.6b4 is the first version in which the changed behavior was documented, and this

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-27 Thread Xiang Zhang
Xiang Zhang added the comment: LGTM. Although at first I am not in favour of this change but searching Github it seems all usages of this API doesn't check the possible error. -- nosy: +xiang.zhang ___ Python tracker

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file45656/PyUnicode_CompareWithASCIIString-no-errors.patch ___ Python tracker

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file45655/PyUnicode_CompareWithASCIIString-no-errors.patch ___ Python tracker

[issue28808] Make PyUnicode_CompareWithASCIIString() never failing

2016-11-26 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: PyUnicode_CompareWithASCIIString() never set an exception in 3.2 and earlier versions. Since 3.3 it sets an exception and returns -1 if the first argument is not ready Unicode object, but this was not documented until issue28701. Due to undocumenting this