[issue28939] Groupby Is Roughly Equivalent To ...

2016-12-11 Thread Greg Solomon
Greg Solomon added the comment: Oh, I get it. There needs to be a next(self.it) loop in __next__ as well as in _grouper in case the user doesn't call _grouper. My test was for ( k , g ) in groupby( L ): print ( k , len( list( g ) ) ) so I was executing _grouper on every row. Thanks !!!

[issue28939] Groupby Is Roughly Equivalent To ...

2016-12-11 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger priority: normal -> low ___ Python tracker

[issue28939] Groupby Is Roughly Equivalent To ...

2016-12-11 Thread Julien Palard
Julien Palard added the comment: I renamed your function groupby2 to compare it with itertools.groupby and tested but: >>> print(list(groupby2(['A', 'B']))) does not returns, looks like your implementation have a bug, so I tried: >>> for k in groupby2(['A', 'B']): ... print(k) and I'm

[issue28939] Groupby Is Roughly Equivalent To ...

2016-12-11 Thread Greg Solomon
New submission from Greg Solomon: https://docs.python.org/3/library/itertools.html#itertools.groupby I found the "equivalent" code a bit hard to read. Is there any merit in changing it to something a bit like the following ? Kind Rgds, Greg class groupby: def __init__( self , iterable ,