[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Serhiy and Victor. The final commits applies the comments. :-) -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Roundup Robot
Roundup Robot added the comment: New changeset e572c323fe53 by Xiang Zhang in branch '3.5': Issue #29044: Fix a use-after-free in string '%c' formatter. https://hg.python.org/cpython/rev/e572c323fe53 New changeset cc61d1d45291 by Xiang Zhang in branch '3.6': Issue #29044: Merge 3.5.

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread STINNER Victor
STINNER Victor added the comment: I reviewed the change and added minor comments. The change LGTM. -- ___ Python tracker ___

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> xiang.zhang nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue29044] Use after free in string '%c' formater

2016-12-21 Thread Xiang Zhang
New submission from Xiang Zhang: In string %c formater(formatchar), when receiving an integer-like objects, the return value is decrefed immediately before use. -- components: Interpreter Core files: use-after-free.patch keywords: patch messages: 283811 nosy: haypo, xiang.zhang