[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Roundup Robot added the comment: New changeset 6bf563472ccd by Vinay Sajip in branch '3.6': Fixes #29177: Improved resilience of logging tests which use socket servers. https://hg.python.org/cpython/rev/6bf563472ccd New changeset 3f324d5df0c0 by Vinay Sajip in branch 'default': Closes #29177:

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Vinay Sajip added the comment: Thanks for the improvements to my patch. The 03-version looks good to me. -- ___ Python tracker ___

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Xavier de Gaye added the comment: issue-29177-02.diff is a modified version of the previous patch that uses support.unlink() instead of os.remove() to handle the failure occuring for a non-existent file when the test is skipped because of Permission denied. With this patch test_logging is ok,

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Changes by Xavier de Gaye : Added file: http://bugs.python.org/file46194/issue-29177-03.patch ___ Python tracker ___

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Vinay Sajip added the comment: > including the SysLogHandlerTest, which wasn't reported Sorry, I appear to have lost the ability to read :-( -- ___ Python tracker

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Vinay Sajip added the comment: I've added a patch that should handle these errors (including the SysLogHandlerTest, which wasn't reported, but I think the same logic applies). To simulate failure during setup, uncomment one or more of the lines which says # raise ValueError('dummy error

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Xavier de Gaye added the comment: > Do you want to take this on, or do you want me to look at it? I would be very grateful if you would handle that :) But if you cannot spare the time, I can give it a try. One point I forgot to mention is that DatagramHandlerTest and SysLogHandlerTest also

[issue29177] skip tests of test_logging when bind() raises PermissionError (non-root user on Android)

Xavier de Gaye added the comment: I have split this issue, issue 29184 is for fixing the tests on test_socketserver and this issue is for fixing the tests on test_logging. -- assignee: xdegaye -> title: skip tests using socketserver.UnixStreamServer when bind() raises PermissionError