[issue29248] os.readlink fails on Windows

Berker Peksag added the comment: Thank you, Craig and SSE4. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker

[issue29248] os.readlink fails on Windows

miss-islington added the comment: New changeset 74ebbaeb566dc10031756430ec5c896e56d0e491 by Miss Islington (bot) in branch '3.7': bpo-29248: Fix os.readlink() on Windows (GH-5577)

[issue29248] os.readlink fails on Windows

Change by miss-islington : -- pull_requests: +5445 ___ Python tracker ___

[issue29248] os.readlink fails on Windows

Berker Peksag added the comment: New changeset a1d33f742515dc70ae99bc3ea1c851729522afc3 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-29248: Fix os.readlink() on Windows (GH-5577)

[issue29248] os.readlink fails on Windows

Change by Berker Peksag : -- versions: -Python 3.5 ___ Python tracker ___ ___

[issue29248] os.readlink fails on Windows

Berker Peksag added the comment: New changeset 3c34aad4e7a95913ec7db8e5e948a8fc69047bf7 by Berker Peksag (SSE4) in branch 'master': bpo-29248: Fix os.readlink() on Windows (GH-5577) https://github.com/python/cpython/commit/3c34aad4e7a95913ec7db8e5e948a8fc69047bf7

[issue29248] os.readlink fails on Windows

Change by miss-islington : -- pull_requests: +5440 ___ Python tracker ___

[issue29248] os.readlink fails on Windows

SSE4 added the comment: opened PR https://github.com/python/cpython/pull/5577 -- nosy: +SSE4 ___ Python tracker ___

[issue29248] os.readlink fails on Windows

Change by Roundup Robot : -- pull_requests: +5395 ___ Python tracker ___

[issue29248] os.readlink fails on Windows

Eryk Sun added the comment: os.symlink calls CreateSymbolicLink, which creates the reparse data buffer with the print name stored first, so the offset is always 0. Otherwise we would have noticed this problem already. For example: >>> os.symlink('C:\\', 'link', True) >>>

[issue29248] os.readlink fails on Windows

Berker Peksag added the comment: Thanks for the patch. I think it would be better to use the existing framework in Win32SymlinkTests to create a test file instead of using a hardcoded path like 'C:\Users\All Users' (e.g. use Win32SymlinkTests.filelink and Win32SymlinkTests.filelink_target to

[issue29248] os.readlink fails on Windows

Craig Holmquist added the comment: New patch with test. I'm not sure if C:\Users\All Users and C:\ProgramData exist with those names on non-English installations of Windows. I set the test to skip if they aren't found. -- nosy: +craigh Added file:

[issue29248] os.readlink fails on Windows

Changes by Craig Holmquist : -- keywords: +patch Added file: http://bugs.python.org/file46290/issue29248.patch ___ Python tracker

[issue29248] os.readlink fails on Windows

New submission from Eryk Sun: win_readlink in Modules/posixmodule.c mistakenly treats the PrintNameOffset field of the reparse data buffer as a number of characters instead of bytes. Thus, if the offset is non-zero, the value returned is incorrect stack garbage. For example, the following