[issue29347] Python could crash while creating weakref for a given object

Changes by Donald Stufft : -- pull_requests: +1086 ___ Python tracker ___ ___

[issue29347] Python could crash while creating weakref for a given object

Changes by Larry Hastings : -- pull_requests: +607 ___ Python tracker ___ ___

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: Thanks for your confirmation Saida! :-) -- ___ Python tracker ___ ___

[issue29347] Python could crash while creating weakref for a given object

Saida Dhanavath added the comment: Hi Xiang, Sorry for the delay. I have not checked my inbox since last week. The proposed fix works for me. -- ___ Python tracker

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: Although no feedback from Saida, but IMHO the problem is solved so I close it now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: New changeset 9a4577a4bb23888fed2cf192cf1a4c95ce5c26f8 by GitHub in branch '3.6': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#186)

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: New changeset 7c95a94c3ab41e4296e94335d66b2400ad16f052 by GitHub in branch '3.5': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#188)

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: New changeset 7131a73f9655cfd325c798385905326f57b94640 by GitHub in branch '2.7': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) (#187)

[issue29347] Python could crash while creating weakref for a given object

Changes by Xiang Zhang : -- pull_requests: +154 ___ Python tracker ___ ___ Python-bugs-list

[issue29347] Python could crash while creating weakref for a given object

Changes by Xiang Zhang : -- pull_requests: +153 ___ Python tracker ___ ___ Python-bugs-list

[issue29347] Python could crash while creating weakref for a given object

Changes by Xiang Zhang : -- pull_requests: +152 ___ Python tracker ___ ___ Python-bugs-list

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: New changeset d0e8212ed70445cc3d48b0d4ae7c9cb480004010 by GitHub in branch 'master': bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref objects (#128) https://github.com/python/cpython/commit/d0e8212ed70445cc3d48b0d4ae7c9cb480004010

[issue29347] Python could crash while creating weakref for a given object

Changes by Xiang Zhang : -- pull_requests: +90 ___ Python tracker ___ ___ Python-bugs-list

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29347] Python could crash while creating weakref for a given object

Saida Dhanavath added the comment: Xiang, Sure, I will run it with other python versions and post the results. -- ___ Python tracker ___

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: Saida, I changed your test program to use set instead of self created type (see attachment). I tested it under Py2.7 and it seems no crash happens. python test.py 1 1 2.7.10 (default, Oct 14 2015, 16:09:02) [GCC 5.2.1 20151010] 0x101010101010101 0x1010101010101

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: But your weakref_crash.c doesn't look correct to me. Your test.object type doesn't support weak references at all. How could you use GET_WEAKREFS_LISTPTR then? See https://docs.python.org/3/extending/newtypes.html#weakref-support. --

[issue29347] Python could crash while creating weakref for a given object

Saida Dhanavath added the comment: Please find the test program attached. Readme.txt has steps to comiple and run program. -- Added file: http://bugs.python.org/file46515/verify_crash_in_weakref.zip ___ Python tracker

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: Hmm, what's your test program? Would you mind show it? -- ___ Python tracker ___

[issue29347] Python could crash while creating weakref for a given object

Saida Dhanavath added the comment: Hi xiang, I have already patched our build environment with the fix and tested it locally. Although I cannot test it in production, have taken out the code of new_weakref, init_weakref and clear_weakref from weakrefobject.c. Changed init_weakref to

[issue29347] Python could crash while creating weakref for a given object

Changes by Xiang Zhang : -- nosy: +fdrake ___ Python tracker ___ ___ Python-bugs-list

[issue29347] Python could crash while creating weakref for a given object

Xiang Zhang added the comment: After reading the code I could see the possibility. A weakref object gets two linkedlist pointers which are not initialized by new_weakref (actually they are initialized by insert_head or insert_after). But the weakref object is possible to be destroyed in [1]