[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset 2b20a37791e3cc4536db1f99fc85ffb6e20134ab by Mariatta Wijaya in branch '2.7': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://github.com/python/cpython/commit/2b20a37791e3cc4536db1f99fc85ffb6e20134ab --

[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset c36939b07c1275a6c3897a917c638b0ac48885c4 by Mariatta Wijaya in branch 'master': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://github.com/python/cpython/commit/c36939b07c1275a6c3897a917c638b0ac48885c4 New changeset

[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset c36939b07c1275a6c3897a917c638b0ac48885c4 by Mariatta Wijaya in branch '3.5': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://github.com/python/cpython/commit/c36939b07c1275a6c3897a917c638b0ac48885c4 --

[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset c36939b07c1275a6c3897a917c638b0ac48885c4 by Mariatta Wijaya in branch '3.6': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://github.com/python/cpython/commit/c36939b07c1275a6c3897a917c638b0ac48885c4 New changeset

[issue29371] Typo in doctest documentation

Mariatta Wijaya added the comment: Thanks, Marco, Jim, and Raymond :) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset 3fd198b80f29 by Mariatta Wijaya in branch '2.7': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://hg.python.org/cpython/rev/3fd198b80f29 -- ___ Python tracker

[issue29371] Typo in doctest documentation

Roundup Robot added the comment: New changeset df62e833eeb1 by Mariatta Wijaya in branch '3.5': Issue #29371: Clarify bitwise OR operation in doctest option flags. https://hg.python.org/cpython/rev/df62e833eeb1 New changeset c3d779f96b20 by Mariatta Wijaya in branch '3.6': Issue #29371: merge

[issue29371] Typo in doctest documentation

Mariatta Wijaya added the comment: Thanks, Raymond. I have an updated patch there the hypen and apostrophe are removed. -- versions: -Python 3.3, Python 3.4 Added file: http://bugs.python.org/file46552/issue29371v2.patch ___ Python tracker

[issue29371] Typo in doctest documentation

Raymond Hettinger added the comment: This mostly looks correct. I would change "bitwise-OR‘ed" to "bitwise ORed". That latter form without the hyphen or apostrophe matches what is used in library/winsound.rst. Once that change is made (in two places), go ahead an apply the patch. --

[issue29371] Typo in doctest documentation

Changes by Mariatta Wijaya : -- stage: -> patch review ___ Python tracker ___ ___

[issue29371] Typo in doctest documentation

Mariatta Wijaya added the comment: Hi everyone, I made a patch to clarify that "or'ed" here really means "bitwise-OR'ed", and made a reference to the section of the docs about bitwise OR. Please review and let me know if this will work. Thanks. -- keywords: +patch Added file:

[issue29371] Typo in doctest documentation

Raymond Hettinger added the comment: Mariatta, would you like to look into this and opine about whether the docs are correct as-is. If you think a change is warranted, propose a patch. -- ___ Python tracker

[issue29371] Typo in doctest documentation

Changes by Raymond Hettinger : -- assignee: docs@python -> Mariatta nosy: +Mariatta, rhettinger ___ Python tracker ___

[issue29371] Typo in doctest documentation

Jim Fasarakis-Hilliard added the comment: I think it is fine as it is but, agree that it could be clearer. I'm simply not experienced enough to know if this change is warranted. The docs generally do a great job in being concise (balancing brevity and completeness). A core-dev would be best

[issue29371] Typo in doctest documentation

Marco Buttu added the comment: What about this? "Symbolic names for the flags are supplied as module constants, which can be OR'ed together (flagA | flagB | ...) and passed to various functions." -- ___ Python tracker

[issue29371] Typo in doctest documentation

Marco Buttu added the comment: I think you got the meaning. I have never read it before :/ If you think the meaning is clear enough for everyone, I close the issue. -- ___ Python tracker

[issue29371] Typo in doctest documentation

Jim Fasarakis-Hilliard added the comment: >From what I understand, "or'ed" here stands for combining the options using >`|` >(https://docs.python.org/3/reference/expressions.html#binary-bitwise-operations). You can see an example of that in the source for `doctest.py`

[issue29371] Typo in doctest documentation

New submission from Marco Buttu: >From the doctest documentation [1]: "Symbolic names for the flags are supplied as module constants, which can be or'ed together and passed to various functions." Is there a typo in "...which can be or'ed together..."? Maybe "collected together"? [1]