[issue29409] Implement PEP 529 for io.FileIO

2018-01-06 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue29409] Implement PEP 529 for io.FileIO

2017-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset fe7e868bad5bffaf863c80fa2bcc4e3bf87a413a by Steve Dower in branch '3.6': Issue #29409: Implement PEP 529 for io.FileIO (Patch by Eryk Sun) https://github.com/python/cpython/commit/fe7e868bad5bffaf863c80fa2bcc4e3bf87a413a --

[issue29409] Implement PEP 529 for io.FileIO

2017-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset fe7e868bad5bffaf863c80fa2bcc4e3bf87a413a by Steve Dower in branch 'master': Issue #29409: Implement PEP 529 for io.FileIO (Patch by Eryk Sun) https://github.com/python/cpython/commit/fe7e868bad5bffaf863c80fa2bcc4e3bf87a413a New changeset

[issue29409] Implement PEP 529 for io.FileIO

2017-02-04 Thread Steve Dower
Steve Dower added the comment: Committed, but I'll leave this open for a bit in case anyone wants to comment on the commit. -- stage: patch review -> commit review ___ Python tracker

[issue29409] Implement PEP 529 for io.FileIO

2017-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0bf72810f8ea by Steve Dower in branch '3.6': Issue #29409: Implement PEP 529 for io.FileIO (Patch by Eryk Sun) https://hg.python.org/cpython/rev/0bf72810f8ea New changeset a5538734cc87 by Steve Dower in branch 'default': Merge issue #28164 and

[issue29409] Implement PEP 529 for io.FileIO

2017-02-04 Thread Steve Dower
Steve Dower added the comment: Merging this in now, along with a few other patches. This is the test I'm adding, in case anyone spots any problems with it before I push (copied from the test for pure-ASCII bytes): @unittest.skipIf(sys.getfilesystemencoding() != 'utf-8',

[issue29409] Implement PEP 529 for io.FileIO

2017-01-31 Thread Eryk Sun
Changes by Eryk Sun : -- stage: needs patch -> test needed ___ Python tracker ___ ___

[issue29409] Implement PEP 529 for io.FileIO

2017-01-31 Thread Eryk Sun
Changes by Eryk Sun : -- keywords: +patch Added file: http://bugs.python.org/file46473/issue_29409_01.patch ___ Python tracker ___

[issue29409] Implement PEP 529 for io.FileIO

2017-01-31 Thread Eryk Sun
New submission from Eryk Sun: PEP 529 isn't implemented for io.FileIO, and I think it should be. If a UTF-8 path is passed to open(), it ends up calling C _open instead of decoding the path and calling C _wopen. Also, if a pathlike object is passed to io.FileIO, it calls PyUnicode_FSConverter