[issue29446] Improve tkinter 'import *' situation

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: New changeset 76b645124b3aaa34bc664eece43707c01ef1b382 by Terry Jan Reedy (Flavian Hautbois) in branch 'master': bpo-29446: tkinter 'import *' only imports what it should (GH-14864)

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: New changeset aee260f1c4d32bf67edec209d949294d4dc403c1 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-29446: IDLE -- add explicit imports (GH-14919) (#14921) https://github.com/python/cpython/commit/aee260f1c4d32bf67edec209d949294d4dc403c1

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: New changeset fc63d5a361f7d20282019cad84336a242c124267 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.8': bpo-29446: IDLE -- add explicit imports (GH-14919) (GH-14920) https://github.com/python/cpython/commit/fc63d5a361f7d20282019cad84336a242c124267

[issue29446] Improve tkinter 'import *' situation

Change by miss-islington : -- pull_requests: +14695 pull_request: https://github.com/python/cpython/pull/14921 ___ Python tracker ___

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: New changeset c6fd6c83b70df76421d05a7628367e64a2f83589 by Terry Jan Reedy in branch 'master': bpo-29446: IDLE -- add explicit imports (GH-14919) https://github.com/python/cpython/commit/c6fd6c83b70df76421d05a7628367e64a2f83589 --

[issue29446] Improve tkinter 'import *' situation

Change by miss-islington : -- pull_requests: +14694 pull_request: https://github.com/python/cpython/pull/14920 ___ Python tracker ___

[issue29446] Improve tkinter 'import *' situation

Change by Terry J. Reedy : -- pull_requests: +14693 pull_request: https://github.com/python/cpython/pull/14919 ___ Python tracker ___

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: I agree that for python x.y, the names imported by 'import *' should be fixed and *not* depend on other imports. -- versions: +Python 3.9 -Python 2.7, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue29446] Improve tkinter 'import *' situation

Serhiy Storchaka added the comment: I prefer Eric's approach. It excludes tkinter submodules (like tkinter.ttk). Currently the result of the star import depends on what submodules were imported before. I think it would be better to make it more stable. --

[issue29446] Improve tkinter 'import *' situation

Change by Flavian Hautbois : -- keywords: +patch pull_requests: +14653 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14864 ___ Python tracker

[issue29446] Improve tkinter 'import *' situation

Change by Manuel Cerón : -- nosy: +ceronman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29446] Improve tkinter 'import *' situation

Changes by Louie Lu : -- nosy: +louielu ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29446] Improve tkinter 'import *' situation

Changes by Serhiy Storchaka : -- keywords: +easy stage: test needed -> needs patch versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue29446] Improve tkinter 'import *' situation

Serhiy Storchaka added the comment: This also excludes "constants" implicitly added by importing names from tkinter.constants. I don't know whether this is good or bad. Interesting, but from tkinter import * import tkinter.ttk and import tkinter.ttk from tkinter import *

[issue29446] Improve tkinter 'import *' situation

Eric V. Smith added the comment: Instead of: __all__ = [name for name in globals() if not name.startswith('_') and name not in {'enum', 're', 'sys', 'wantobjects'}] Maybe this would be less fragile: import types __all__ = [name for name, obj in globals().items() if not name.startswith('_')

[issue29446] Improve tkinter 'import *' situation

Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29446] Improve tkinter 'import *' situation

Terry J. Reedy added the comment: This issue is spun-off from #29162, which was about idlelib.pyshell depending on import * importing sys. 'wantobjects' does not have the same bug potential as stdlib imports. But, Serhiy, if you care about it or otherwise prefer __all__, __all__ = [name for

[issue29446] Improve tkinter 'import *' situation

Serhiy Storchaka added the comment: There is yet one name that doesn't make sense to import -- wantobjects. It can't be renamed. -- ___ Python tracker

[issue29446] Improve tkinter 'import *' situation

Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___

[issue29446] Improve tkinter 'import *' situation

New submission from Terry J. Reedy: Tkinter naming was designed so that 'from tkinter import *' can work, in the sense of not conflicting with built-in and stdlib module names. But there are currently two problems. 1. The current doc ...to use Tkinter all you need is a simple import