[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: New changeset c22bfaae83ab5436d008ac0d13e7b47cbe776f08 by Victor Stinner in branch 'master': bpo-29524: Add Objects/call.c file (#12) https://github.com/python/cpython/commit/c22bfaae83ab5436d008ac0d13e7b47cbe776f08 --

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: commit c22bfaae83ab5436d008ac0d13e7b47cbe776f08 Author: Victor Stinner Date: Sun Feb 12 19:27:05 2017 +0100 bpo-29524: Add Objects/call.c file (#12) * Move all functions to call objects in a new Objects/call.c file.

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: Benchmarks results. I don't know if the speedup is purely random, if I was just lucky, or if the change really makes Python faster... spectral_norm is a benchmark highly impacted by code placement. haypo@speed-python$ python3 -m perf compare_to

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: We have moved to GitHub and mandatory reviews with Pull Requests. So I created the PR #12 and removed the patch attached to this issue to avoid confusion. -- ___ Python tracker

[issue29524] Move functions to call objects into a new Objects/call.c file

Changes by STINNER Victor : Removed file: http://bugs.python.org/file46624/call.patch ___ Python tracker ___

[issue29524] Move functions to call objects into a new Objects/call.c file

Changes by STINNER Victor : -- pull_requests: +28 ___ Python tracker ___ ___

[issue29524] Move functions to call objects into a new Objects/call.c file

Serhiy Storchaka added the comment: It is hard to make a review of changes of such kind. Common reviewing tools don't help with this. I would suggest you to make a series of commits that move a code from different files after migrating to Git. It may be easier to make a post-commit review. I

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: Oh, it's painful to have reviews and comments in two websites. Serhiy left a comment on the review in fact: "Should be added also in PCbuild/pythoncore.vcxproj.filters." -- ___ Python tracker

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: Serhiy Storchaka added the comment: > I would delay pushing this change until CPython repository be converted to > Git. I heard Git better supports moving a code between files. And perhaps it > might be easier to do this change by several commits -- separately

[issue29524] Move functions to call objects into a new Objects/call.c file

Serhiy Storchaka added the comment: I like the idea of moving all code related to calling objects in one one file. But this has a drawback. This breaks a history. This makes harder code exploration and merging. I would delay pushing this change until CPython repository be converted to Git. I

[issue29524] Move functions to call objects into a new Objects/call.c file

STINNER Victor added the comment: See also issue #29502 "Should PyObject_Call() call the profiler on C functions, use C_TRACE() macro?": fixing this one should allow to remove fast-paths from ceval.c, since we now already have fast-paths in all "call" functions. --

[issue29524] Move functions to call objects into a new Objects/call.c file

New submission from STINNER Victor: I propose to move functions to call objects into a new Objects/call.c file. It should easy maintainance since all moved functions are inter-dependent: it becomes easier to keep them consistent since they are in the same fle. I also have a small "hope" that