[issue29648] Missed reference to create_module() in versionadded (import.rst)

Mariatta Wijaya added the comment: New changeset 63ed9bc94d8df45b16aee9b92f658ebb34aa1012 by Mariatta in branch '3.5': bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-315) https://github.com/python/cpython/commit/63ed9bc94d8df45b16aee9b92f658ebb34aa1012 --

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Mariatta Wijaya added the comment: New changeset 46ce7599af82a929506baeaaee5c149970440c4c by Mariatta (Marco Buttu) in branch 'master': bpo-29648: import.rst: Add reference to create_module() (GH-290) https://github.com/python/cpython/commit/46ce7599af82a929506baeaaee5c149970440c4c

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Mariatta Wijaya added the comment: New changeset 7333d1760e12cf27bcf63265f72521892285c10a by Mariatta in branch '3.6': bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-314) https://github.com/python/cpython/commit/7333d1760e12cf27bcf63265f72521892285c10a --

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Mariatta Wijaya added the comment: Thanks for the clarification, Nick :) Marco, I merged your PR, and backported to 3.5 and 3.6 branches. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Changes by Mariatta Wijaya : -- pull_requests: +276 ___ Python tracker ___ ___

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Changes by Mariatta Wijaya : -- pull_requests: +275 ___ Python tracker ___ ___

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Nick Coghlan added the comment: Version added is correct here, as the "create_module()" methods are all new in 3.4, and the traditional granularity for deciding "addition or change?" is that new functions, methods, and attributes are always additions, even if they're being added to a class

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Changes by Serhiy Storchaka : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Mariatta Wijaya added the comment: Thanks, Marco. Your change looks good to me. I'm now wondering if this should have been 'versionchanged' instead of 'versionadded'. Perhaps other core devs can confirm this. Thanks :) -- assignee: -> docs@python components: +Documentation nosy:

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Changes by Marco Buttu : -- pull_requests: +261 ___ Python tracker ___ ___

[issue29648] Missed reference to create_module() in versionadded (import.rst)

Changes by Mariatta Wijaya : -- pull_requests: +260 ___ Python tracker ___ ___

[issue29648] Missed reference to create_module() in versionadded (import.rst)

New submission from Marco Buttu: In the first `versionadded` of the Loader section [1] of Doc/reference/import.rst, there is no reference to `create_module()`: .. versionadded:: 3.4 The create_module() method of loaders. It should be: .. versionadded:: 3.4 The